Skip conversion when converted file already exists in source library#6
Merged
Merged
Conversation
When a device requires a different file type (e.g. mp3) and the source library already contains a file with that extension (e.g. track.mp3 alongside track.aiff), convert_file would still attempt to transcode the original. Add a check so that if the source directory already has a file with the target extension, the conversion is skipped — the existing source file will be picked up by the sync loop and copied directly instead. https://claude.ai/code/session_012Aej1UZqDBLaQW2rZ799zo
Follow the same pattern as analyzer_test.rb: require real Audio, UI, and Scanner files, then use mocha class-level stubs to control behavior rather than defining fake stub classes inline. https://claude.ai/code/session_012Aej1UZqDBLaQW2rZ799zo
pixelate
force-pushed
the
claude/fix-sync-conversion-skip-xISkm
branch
from
5e980ca to
76aa9e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a device requires a different file type (e.g. mp3) and the source
library already contains a file with that extension (e.g. track.mp3 alongside
track.aiff), convert_file would still attempt to transcode the original.
Add a check so that if the source directory already has a file with the
target extension, the conversion is skipped — the existing source file
will be picked up by the sync loop and copied directly instead.