Uppercase folder and file names when syncing to TP-7#64
Merged
Conversation
The TP-7 display can only show uppercase letters, so paths on the device should be uppercase. Adding uppercase_paths: true to the TP-7 device config causes PathResolver to upcase all relative path components (folders and filename including extension) after applying other transforms (unsupported character stripping, file type changes). Pull still works: prepare!() stores device files in the staging directory using the device's actual paths (uppercase), and pull_cue_points resolves the same uppercase paths via PathResolver, so the two sides match.
pixelate
force-pushed
the
claude/uppercase-tp7-sync-d2Acs
branch
from
abcf3d1 to
dd63fc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TP-7 display can only show uppercase letters, so paths on the device
should be uppercase. Adding uppercase_paths: true to the TP-7 device config
causes PathResolver to upcase all relative path components (folders and
filename including extension) after applying other transforms (unsupported
character stripping, file type changes).
Pull still works: prepare!() stores device files in the staging directory
using the device's actual paths (uppercase), and pull_cue_points resolves
the same uppercase paths via PathResolver, so the two sides match.