Introduce AudioFormat value object to reduce parameter counts#8
Merged
Conversation
Groups file_type, sample_rate, and bit_depth into a single AudioFormat Data object. Adds Audio#format and Device#target_format as named constructors, reducing FileConverter#convert from 9 to 5 params and UI#conversion_progress from 6 to 2 params. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pixelate
force-pushed
the
claude/add-audio-format-type
branch
from
64d2f81 to
9222181
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AudioFormat = Data.define(:file_type, :sample_rate, :bit_depth)as a new value objectAudio#formatandDevice#target_formatas named constructors so call sites never buildAudioFormatrawFileConverter#convertfrom 9 params to 5,UI#conversion_progressfrom 6 to 2,UI#copyfrom 3 to 1Audio,Device, andFileConverterto cover the new type and methods