Merged
Conversation
Comprehensive fixes for running as any non-root UID (Kubernetes, OpenShift, Docker Compose PUID/PGID): Dockerfile (core): - /etc/passwd and /etc/group world-writable for runtime injection - /app/.venv/bin writable for pip entry point scripts - /app and /app/ComfyUI writable for startup dir creation - Dynamic Python version detection (no hardcoded python3.12) - PYTHONDONTWRITEBYTECODE=1 to suppress .pyc permission failures - SHELL pipefail in final stage (not inherited across FROM) Dockerfile (complete): - Re-apply world-writable permissions after pip install layer - SHELL pipefail for safety - Dynamic Python version detection Entrypoint: - Inject both /etc/passwd and /etc/group for arbitrary UIDs - Use getent passwd instead of whoami for reliable UID detection - Use unique username (comfyuser) to avoid collision with build-time comfy user at UID 1000 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ductiletoaster
force-pushed
the
fix/non-root-support
branch
from
c51f562 to
a4ee3b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Review
Description
Please include a summary of the changes including relevant motivation and context. List any dependencies that are required for this change.
Please check the option(s) that are most relevant.
Testing & Verification
Please describe the tests that you ran to verify your changes.