Refactor indirection analysis helpers#10
Merged
pixge merged 1 commit intocodex/modify-scaffolding-and-implement-loggingfrom Jan 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
IndirectionAnalyzer.analyze_filefunction had many conditionals and responsibilities, making it hard to read and maintain.Description
_collect_builtin_names,_collect_stdlib_modules, and_collect_unit_callsto encapsulate environment and call collection steps._build_results,_class_context,_resolve_unit_calls,_resolve_self_call, and_is_ignorable_callto handle per-unit call resolution and result construction.call_graphcomputation via the existing_resolve_aliasand_collect_call_graphlogic, and replaced inline logic with calls to the new helpers.report.jsonto reflect updated metrics after the refactor.Testing
python3 -m codra.cli.main /workspace/codra --output /workspace/codra/report.jsonand it completed successfully with the report written to/workspace/codra/report.json.Codex Task