Fix rendering UDFs with variable arguments#191
Merged
vihangm merged 1 commit intopixie-io:mainfrom Jun 7, 2022
Merged
Conversation
Signed-off-by: Phillip Kuznetsov <pkuznetsov@pixielabs.ai>
✅ Deploy Preview for docs-px-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
vihangm
approved these changes
Jun 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new UDF has variable arguments and we need to support them.
Tested by using that new generated doc file and made sure it works. Previously that file failed here:
#189
Signed-off-by: Phillip Kuznetsov pkuznetsov@pixielabs.ai