Skip to content

Fix url / header links#208

Merged
aimichelle merged 15 commits intomainfrom
netlify-checklinks-plugin
Jul 6, 2022
Merged

Fix url / header links#208
aimichelle merged 15 commits intomainfrom
netlify-checklinks-plugin

Conversation

@htroisi
Copy link
Copy Markdown
Contributor

@htroisi htroisi commented Jun 24, 2022

Signed-off-by: Hannah Troisi htroisi@pixielabs.ai

Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai>
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 24, 2022

Deploy Preview for docs-px-dev ready!

Name Link
🔨 Latest commit 488eb43
🔍 Latest deploy log https://app.netlify.com/sites/docs-px-dev/deploys/62b6315bdcb96d008b75f0bb
😎 Deploy Preview https://deploy-preview-208--docs-px-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai>
@htroisi htroisi force-pushed the netlify-checklinks-plugin branch from feae687 to 8e42113 Compare June 24, 2022 18:40
htroisi added 10 commits June 24, 2022 11:50
Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai>
Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai>
Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai>
Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai>
Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai>
Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai>
Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai>
Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai>
Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai>
Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai>
@htroisi htroisi marked this pull request as draft June 24, 2022 20:25
htroisi added 2 commits June 24, 2022 13:49
Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai>
Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai>
---

### General
**General**
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to make this body text (and not H3) because there's a weird bug with our docs.px.dev website where it doesn't like the fact that these H3 don't have an H2 parent. h-links for H3 are of the format #-H2-H3 and these links get random H2 parents that can be brokenlinks.

---

### Pixie Operator
## Pixie Operator
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue with H3 headers not having H2 parents.

Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai>
@htroisi htroisi requested a review from vihangm June 24, 2022 21:38
@htroisi htroisi changed the title Add Netlify checklinks plugin Fix h-links to prep for adding Netlify checklinks plugin Jun 24, 2022
@htroisi htroisi marked this pull request as ready for review June 24, 2022 21:38
@htroisi htroisi changed the title Fix h-links to prep for adding Netlify checklinks plugin Fix url / header links Jul 6, 2022
@htroisi htroisi requested a review from aimichelle July 6, 2022 22:32
@aimichelle aimichelle merged commit f6f45da into main Jul 6, 2022
@aimichelle aimichelle deleted the netlify-checklinks-plugin branch July 6, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants