Update perf_profiler_bpf_test to use UnitConnector.#1283
Merged
JamesMBartlett merged 3 commits intopixie-io:mainfrom May 9, 2023
Merged
Conversation
ddelnano
reviewed
May 4, 2023
ddelnano
reviewed
May 4, 2023
ddelnano
reviewed
May 4, 2023
ddelnano
reviewed
May 4, 2023
Signed-off-by: Pete Stevenson <jps@pixielabs.ai>
etep
force-pushed
the
ddh-convert-perf-profiler-test-cases-to-unit-connector
branch
from
091704f to
fd698ee
Compare
added 2 commits
May 5, 2023 15:06
ddelnano
approved these changes
May 8, 2023
| std::vector<std::unique_ptr<ContainerRunner>> sub_processes_; | ||
| }; | ||
|
|
||
| template <bool FastTest> |
Member
There was a problem hiding this comment.
Could you explain fast tests vs slow tests? I don't really understand what we're trying to achieve with the distinction.
Author
There was a problem hiding this comment.
The "slow" test accepts all the default profiler parameters, but with the 30 sec. data sampling periodicity, the test inherently runs slower. The "fast" test overrides the defaults, but the test case will complete in less time. At some point in the history, we had (or were going toward) all tests using the "fast" methodology but a reviewer suggested that we keep at least one test with the slow/default setup. This PR does not change the existing setup, but it does provide a nicer way to identify which test is in which category by naming the templated test fixtures accordingly.
JamesMBartlett
approved these changes
May 9, 2023
ddelnano
pushed a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
Summary: we convert `perf_profiler_bpf_test` to use `UnitConnector` to share code across different tests and binaries. We also refactor the Java test case to separately test the expectation that Java symbolization artifacts are removed after processes stop. The main Java test case then conforms to the pattern established for Go and cpp. We also update some of the helper functions in the test to tidy up the common test cases. Type of change: /kind cleanup Test Plan: existing tests & runs per test. - [x] `bazel test //src/stirling/source_connectors/perf_profiler/... --config bpf --runs_per_test 16` ([all tests passed](https://phab.corp.pixielabs.ai/P372)). --------- Signed-off-by: Pete Stevenson <jps@pixielabs.ai>
ddelnano
pushed a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
Summary: we convert `perf_profiler_bpf_test` to use `UnitConnector` to share code across different tests and binaries. We also refactor the Java test case to separately test the expectation that Java symbolization artifacts are removed after processes stop. The main Java test case then conforms to the pattern established for Go and cpp. We also update some of the helper functions in the test to tidy up the common test cases. Type of change: /kind cleanup Test Plan: existing tests & runs per test. - [x] `bazel test //src/stirling/source_connectors/perf_profiler/... --config bpf --runs_per_test 16` ([all tests passed](https://phab.corp.pixielabs.ai/P372)). --------- Signed-off-by: Pete Stevenson <jps@pixielabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: we convert
perf_profiler_bpf_testto useUnitConnectorto share code across different tests and binaries.We also refactor the Java test case to separately test the expectation that Java symbolization artifacts are removed after processes stop. The main Java test case then conforms to the pattern established for Go and cpp.
We also update some of the helper functions in the test to tidy up the common test cases.
Type of change: /kind cleanup
Test Plan: existing tests & runs per test.
bazel test //src/stirling/source_connectors/perf_profiler/... --config bpf --runs_per_test 16(all tests passed).