Move pprof into shared sub-tree.#1290
Merged
vihangm merged 5 commits intopixie-io:mainfrom May 8, 2023
Merged
Conversation
added 2 commits
May 5, 2023 09:27
Signed-off-by: Pete Stevenson <jps@pixielabs.ai>
Signed-off-by: Pete Stevenson <jps@pixielabs.ai>
added 2 commits
May 5, 2023 09:36
ddelnano
approved these changes
May 8, 2023
Signed-off-by: Pete Stevenson <jps@pixielabs.ai>
JamesMBartlett
approved these changes
May 8, 2023
ddelnano
pushed a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
Summary: We meed to move this code into a location that can be shared between `stirling` and `carnot`. Type of change: /kind cleanup Test Plan: The pprof export code will be integrated into a future diff. We have tested it locally using the `stirling_profiler` binary. Its test case will live inside of the (future work) `carnot` UDA that generates a profiling pprof protobuf for export. Signed-off-by: Pete Stevenson <jps@pixielabs.ai>
ddelnano
pushed a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
Summary: We meed to move this code into a location that can be shared between `stirling` and `carnot`. Type of change: /kind cleanup Test Plan: The pprof export code will be integrated into a future diff. We have tested it locally using the `stirling_profiler` binary. Its test case will live inside of the (future work) `carnot` UDA that generates a profiling pprof protobuf for export. Signed-off-by: Pete Stevenson <jps@pixielabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: We meed to move this code into a location that can be shared between
stirlingandcarnot.Type of change: /kind cleanup
Test Plan: The pprof export code will be integrated into a future diff. We have tested it locally using the
stirling_profilerbinary. Its test case will live inside of the (future work)carnotUDA that generates a profiling pprof protobuf for export.