Update tcp_stats_bpf_test to work with qemu#1308
Merged
vihangm merged 1 commit intopixie-io:mainfrom May 11, 2023
Merged
Conversation
ddelnano
changed the title
tcp_stats_bpf_test to work with qemu
ddelnano
commented
May 9, 2023
ddelnano
force-pushed
the
ddelnano/fix-tcp_stats_trace_bpf_test-with-qemu
branch
from
166f84a to
c0c5246
Compare
Member
Author
|
/perf nightly |
1 similar comment
Member
Author
|
/perf nightly |
ddelnano
force-pushed
the
ddelnano/fix-tcp_stats_trace_bpf_test-with-qemu
branch
from
495f313 to
6dea43c
Compare
Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
ddelnano
force-pushed
the
ddelnano/fix-tcp_stats_trace_bpf_test-with-qemu
branch
from
7fd3bfe to
0459333
Compare
JamesMBartlett
approved these changes
May 10, 2023
etep
approved these changes
May 10, 2023
vihangm
pushed a commit
that referenced
this pull request
May 11, 2023
Summary: Remove `no_qemu` tag for tcp_stats_bpf_test The long lived PR for adding our CI jobs to GitHub actions finished up just as the qemu incompatibility was addressed. We can now opt this test into qemu testing. Relevant Issues: N/A Type of change: /kind buf Test Plan: Verified in #1308 that this test works with qemu Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
ddelnano
added a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
Summary: Update `tcp_stats_bpf_test` to work with qemu Relevant Issues: N/A Type of change: /kind bug Test Plan: Verified that the test ran successfully for our various test runners - [x] Running test multiple times within docker to verify that adding the `nc` server doesn't cause flakiness ([P376](https://phab.corp.pixielabs.ai/P376)). Also verified that each test is in its own network namespace so that the servers can't conflict with each other ([P378](https://phab.corp.pixielabs.ai/P378)) - [x] Running test within qemu passes ([P377](https://phab.corp.pixielabs.ai/P377)) - [x] Verified that when a test times out that the test prints the accumulated records found (otherwise it's difficult to see why the assertion failed) - [P379](https://phab.corp.pixielabs.ai/P379) Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
ddelnano
added a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
Summary: Remove `no_qemu` tag for tcp_stats_bpf_test The long lived PR for adding our CI jobs to GitHub actions finished up just as the qemu incompatibility was addressed. We can now opt this test into qemu testing. Relevant Issues: N/A Type of change: /kind buf Test Plan: Verified in pixie-io#1308 that this test works with qemu Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
ddelnano
added a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
Summary: Update `tcp_stats_bpf_test` to work with qemu Relevant Issues: N/A Type of change: /kind bug Test Plan: Verified that the test ran successfully for our various test runners - [x] Running test multiple times within docker to verify that adding the `nc` server doesn't cause flakiness ([P376](https://phab.corp.pixielabs.ai/P376)). Also verified that each test is in its own network namespace so that the servers can't conflict with each other ([P378](https://phab.corp.pixielabs.ai/P378)) - [x] Running test within qemu passes ([P377](https://phab.corp.pixielabs.ai/P377)) - [x] Verified that when a test times out that the test prints the accumulated records found (otherwise it's difficult to see why the assertion failed) - [P379](https://phab.corp.pixielabs.ai/P379) Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
ddelnano
added a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
Summary: Remove `no_qemu` tag for tcp_stats_bpf_test The long lived PR for adding our CI jobs to GitHub actions finished up just as the qemu incompatibility was addressed. We can now opt this test into qemu testing. Relevant Issues: N/A Type of change: /kind buf Test Plan: Verified in pixie-io#1308 that this test works with qemu Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Update
tcp_stats_bpf_testto work with qemuRelevant Issues: N/A
Type of change: /kind bug
Test Plan: Verified that the test ran successfully for our various test runners
ncserver doesn't cause flakiness (P376). Also verified that each test is in its own network namespace so that the servers can't conflict with each other (P378)