[build-and-test] Remove custom name from matrix checks.#1316
Merged
JamesMBartlett merged 1 commit intopixie-io:mainfrom May 10, 2023
Merged
[build-and-test] Remove custom name from matrix checks.#1316JamesMBartlett merged 1 commit intopixie-io:mainfrom
JamesMBartlett merged 1 commit intopixie-io:mainfrom
Conversation
vihangm
approved these changes
May 9, 2023
JamesMBartlett
force-pushed
the
fallback_name
branch
from
0cf39c3 to
3389fd7
Compare
JamesMBartlett
changed the title
JamesMBartlett
added a commit
that referenced
this pull request
May 9, 2023
Summary: Passing the full github context to `matrix.sh` was unreliable, instead just pass the things we need. Type of change: /kind test-infra Test Plan: Testing with this PR, also rebasing #1316 which previously failed to make sure it doesn't anymore. Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
JamesMBartlett
force-pushed
the
fallback_name
branch
from
3389fd7 to
0337677
Compare
Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
JamesMBartlett
force-pushed
the
fallback_name
branch
from
0337677 to
3bb0414
Compare
JamesMBartlett
changed the title
JamesMBartlett
force-pushed
the
fallback_name
branch
from
b1b75be to
3bb0414
Compare
ddelnano
pushed a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
…#1317) Summary: Passing the full github context to `matrix.sh` was unreliable, instead just pass the things we need. Type of change: /kind test-infra Test Plan: Testing with this PR, also rebasing pixie-io#1316 which previously failed to make sure it doesn't anymore. Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
ddelnano
pushed a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
Summary: When there are no matrix configs to run, without this change, a
check is added with an ugly ${{ matrix.name }}. This PR removes the
custom naming, which removes the ugly ${{matrix.name}}
Type of change: /kind cleanup
Test Plan: Testing with this PR, since there shouldn't be any matrix
configs to run.
Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
ddelnano
pushed a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
…#1317) Summary: Passing the full github context to `matrix.sh` was unreliable, instead just pass the things we need. Type of change: /kind test-infra Test Plan: Testing with this PR, also rebasing pixie-io#1316 which previously failed to make sure it doesn't anymore. Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
ddelnano
pushed a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
Summary: When there are no matrix configs to run, without this change, a
check is added with an ugly ${{ matrix.name }}. This PR removes the
custom naming, which removes the ugly ${{matrix.name}}
Type of change: /kind cleanup
Test Plan: Testing with this PR, since there shouldn't be any matrix
configs to run.
Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: When there are no matrix configs to run, without this change, a check is added with an ugly ${{ matrix.name }}. This PR removes the custom naming, which removes the ugly ${{matrix.name}}
Type of change: /kind cleanup
Test Plan: Testing with this PR, since there shouldn't be any matrix configs to run.