Skip to content

Update dropdown styling#1345

Merged
aimichelle merged 4 commits intopixie-io:mainfrom
NickLanam:dropdown-style
May 17, 2023
Merged

Update dropdown styling#1345
aimichelle merged 4 commits intopixie-io:mainfrom
NickLanam:dropdown-style

Conversation

@NickLanam
Copy link
Copy Markdown
Member

@NickLanam NickLanam commented May 16, 2023

Summary: Rounds off borders, changes colors somewhat, and visually connects the dropdown with its anchor.

new-dropdowns.mp4

Relevant Issues: #1174

Type of change: /kind cleanup

Test Plan: In the Live view, play with the cluster selector, the script selector, and the arguments. Try scripts that have several arguments, too.

@NickLanam NickLanam requested review from aimichelle and vihangm May 16, 2023 20:01
@NickLanam NickLanam marked this pull request as ready for review May 16, 2023 20:44
Comment thread src/ui/src/components/breadcrumbs/breadcrumbs.tsx Outdated
NickLanam added 4 commits May 17, 2023 15:37
Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
@aimichelle aimichelle merged commit 8111b1c into pixie-io:main May 17, 2023
@NickLanam NickLanam deleted the dropdown-style branch May 17, 2023 23:25
ddelnano pushed a commit to k8sstormcenter/pixie that referenced this pull request Feb 25, 2026
Summary: Rounds off borders, changes colors somewhat, and visually
connects the dropdown with its anchor.


https://github.com/pixie-io/pixie/assets/314133/5d48cee2-4230-4474-b11d-7bb2e1556d0a

Relevant Issues: pixie-io#1174

Type of change: /kind cleanup

Test Plan: In the Live view, play with the cluster selector, the script
selector, and the arguments. Try scripts that have several arguments,
too.

---------

Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
ddelnano pushed a commit to k8sstormcenter/pixie that referenced this pull request Feb 25, 2026
Summary: Rounds off borders, changes colors somewhat, and visually
connects the dropdown with its anchor.


https://github.com/pixie-io/pixie/assets/314133/5d48cee2-4230-4474-b11d-7bb2e1556d0a

Relevant Issues: pixie-io#1174

Type of change: /kind cleanup

Test Plan: In the Live view, play with the cluster selector, the script
selector, and the arguments. Try scripts that have several arguments,
too.

---------

Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants