Add user deletion to API service #1439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
need to rebase |
Signed-off-by: Michelle Nguyen <michellenguyen@pixielabs.ai>
JamesMBartlett
approved these changes
Jun 6, 2023
src/api/proto/cloudpb/cloudapi.proto
Outdated
| } | ||
|
|
||
| // DeleteUserRequest is a request to delete a user. This request must be made with the user's | ||
| // credentials. |
Member
There was a problem hiding this comment.
maybe add a comment that it deletes the org if the user is the last one in the org
Signed-off-by: Michelle Nguyen <michellenguyen@pixielabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We are adding user deletion to the API. #1434 added user deletion to the internal profile service. This PR adds it to the external-facing gRPC API. A followup diff will later add it to gql.
Relevant Issues: #655
Type of change: /kind feature
Test Plan: unit tests