Skip to content

Conversation

@aimichelle
Copy link
Member

Summary: #1368 added the ability to limit the metadata service to specific namespaces. By default, if no namespaces are mentioned, the flag is supposed to choose all namespaces.
However, if the environment variable is not specified, it is actually parsed as an empty list and the default is not properly chosen. Instead, we can assume no users actually want to watch 0 namespaces, and set it to all namespaces when that occurs.

Relevant Issues: N/A

Type of change: /kind bug

Test Plan: Skaffold deploy metadata service

Signed-off-by: Michelle Nguyen <michellenguyen@pixielabs.ai>
@ddelnano
Copy link
Member

What is injecting the environment variable? Is that the px or helm deploy? I scanned #1368 and didn't see where what env var is bound to that flag.

@aimichelle
Copy link
Member Author

What is injecting the environment variable? Is that the px or helm deploy? I scanned #1368 and didn't see where what env var is bound to that flag.

We should probably add it to both px and helm to inject the environment variable. Currently you can only add it by either manually editing the metadata deployment, or adding it as a "patch" in px/helm.

@aimichelle aimichelle merged commit 0a41aaa into pixie-io:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants