Fix and re-enable partial aggregates.#1702
Merged
JamesMBartlett merged 7 commits intopixie-io:mainfrom Sep 22, 2023
Merged
Conversation
added 2 commits
September 11, 2023 16:52
Signed-off-by: Pete Stevenson <jps@pixielabs.ai>
ddelnano
reviewed
Sep 13, 2023
JamesMBartlett
approved these changes
Sep 18, 2023
ddelnano
approved these changes
Sep 20, 2023
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Oct 2, 2023
This reverts commit 2645963.
4 tasks
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Oct 3, 2023
This reverts commit 2645963. Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
ddelnano
pushed a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
Summary: The implementation of the "any" UDA was broken for partial aggregates. In this PR, we fix that and re-enable partial aggregates. Type of change: /kind bug fix Test Plan: We add two new test cases: `MergeAnyUDA` and `SerDesAnyUDA`. - [x] Both new test cases fail with the original UDA impl. - [x] Both new test cases pass with the fixed UDA impl. (this PR). - [x] Skaffolded up the new impl. and verified that flamegraphs render correctly. --------- Signed-off-by: Pete Stevenson <jps@pixielabs.ai>
ddelnano
pushed a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
Summary: The implementation of the "any" UDA was broken for partial aggregates. In this PR, we fix that and re-enable partial aggregates. Type of change: /kind bug fix Test Plan: We add two new test cases: `MergeAnyUDA` and `SerDesAnyUDA`. - [x] Both new test cases fail with the original UDA impl. - [x] Both new test cases pass with the fixed UDA impl. (this PR). - [x] Skaffolded up the new impl. and verified that flamegraphs render correctly. --------- Signed-off-by: Pete Stevenson <jps@pixielabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: The implementation of the "any" UDA was broken for partial aggregates. In this PR, we fix that and re-enable partial aggregates.
Type of change: /kind bug fix
Test Plan: We add two new test cases:
MergeAnyUDAandSerDesAnyUDA.