Upgrade rules_scala and rules_meta
#2293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelnano
force-pushed
the
ddelnano/upgrade-rules_scala-and-meta
branch
from
e8b3dc6 to
c00c23b
Compare
ddelnano
added a commit
that referenced
this pull request
Dec 16, 2025
…eps (#2290) Summary: Upgrade Bazel from 6.2.0 to 6.5.0 along with protobuf, tensorflow, and related dependencies. This is a coordinated upgrade since these dependencies have hard interdependencies that make incremental upgrades difficult. Key changes - Upgrade Bazel from 6.2.0 to 6.5.0 (required by these new dependencies) - Protobuf upgrade with compatibility patches for text format handling and JavaScript generation - TensorFlow upgrade with patches to disable GPU/LLVM/Python features. The GPU disable patch will not be necessary as TensorFlow's fallback logic will work with Bazel 7 - gRPC-web upgrade to 2.0.2 and replacement of the vendored `protoc-gen-grpc-web` with a Bazel repository - Flatbuffers patched to remove rules_js dependency (this upgrade is required by TensorFlow v2.20.0) - absl upgrade (causes transitive header changes) - Regenerated TypeScript protobuf bindings for the UI I attempted to split this into a smaller change in #2296. TensorFlow has a tight dependency on protobuf, which prevented that attempt from working. I'm open to other ideas on how to split this up, but so far this seemed like the best balance with #2293 and #2297 to follow to complete the Bazel 7 migration. Relevant Issues: #2282 Type of change: /kind cleanup Test Plan: Build passes --------- Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com> (cherry picked from commit 430eb96)
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
force-pushed
the
ddelnano/upgrade-rules_scala-and-meta
branch
from
9d9119a to
5613047
Compare
vihangm
approved these changes
Dec 16, 2025
Comment on lines
+512
to
+516
| REPOSITORY_LOCATIONS["with_cfg.bzl"] = dict( | ||
| sha256 = "c7af6227d24499438fa0bb96fe4034e163d8c807b06f7c0645f3654448268b84", | ||
| strip_prefix = "with_cfg.bzl-0.11.0", | ||
| urls = ["https://github.com/fmeum/with_cfg.bzl/releases/download/v0.11.0/with_cfg.bzl-v0.11.0.tar.gz"], | ||
| ) |
Member
There was a problem hiding this comment.
any reason not to stick it inline above? you might need to quote the key I guess?
Member
Author
There was a problem hiding this comment.
I believe the dict() function expects the key (kwarg) to be a valid identifier. Since with_cfg.bzl contains a period, I wasn't able to get this to work another way.
I was going to start moving dependencies to bzlmod after #2297 and this was one of the dependencies I intended to move initially. So this will get cleaned up quickly.
vihangm
reviewed
Dec 16, 2025
ddelnano
force-pushed
the
ddelnano/upgrade-rules_scala-and-meta
branch
from
7ff4375 to
5613047
Compare
ddelnano
commented
Dec 16, 2025
Comment on lines
-68
to
70
| return rule( | ||
| name = "sysroot_{variant}_image".format(variant = variant), | ||
| implementation = _impl, | ||
| attrs = dicts.add(_container.image.attrs, { | ||
| "default_image": attr.label(mandatory = True, doc = "Default container_image to use if no sysroot toolchain is found"), |
Member
Author
There was a problem hiding this comment.
This change fixes the following error:
root@px-dev-docker-hacksaw:/px/src/px.dev/pixie# bazel build @com_github_iovisor_bpftrace//:bpftrace --verbose_failures
ERROR: Traceback (most recent call last):
File "/px/src/px.dev/pixie/bazel/cc_toolchains/sysroots/images.bzl", line 82, column 55, in <toplevel>
sysroot_runtime_image = _sysroot_variant_image_factory("runtime")
File "/px/src/px.dev/pixie/bazel/cc_toolchains/sysroots/images.bzl", line 67, column 16, in _sysroot_variant_image_factory
return rule(
Error in rule: in call to rule(), parameter 'name' is deprecated and will be removed soon. It may be temporarily re-enabled by setting --incompatible_remove_rule_name_parameter=false
ERROR: /root/.cache/bazel/_bazel_root/54060b0ed2e63c063d495ae4fb1a7d19/external/com_github_iovisor_bcc/BUILD.bazel:27:6: error loading package '': initialization of module 'bazel/cc_toolchains/sysroots/images.bzl' failed and referenced by '@com_github_iovisor_bcc//:bcc'
ERROR: /root/.cache/bazel/_bazel_root/54060b0ed2e63c063d495ae4fb1a7d19/external/com_github_iovisor_bpftrace/BUILD.bazel:27:6: error loading package '': initialization of module 'bazel/cc_toolchains/sysroots/images.bzl' failed and referenced by '@com_github_iovisor_bpftrace//:bpftrace'
ERROR: Analysis of target '@com_github_iovisor_bpftrace//:bpftrace' failed; build aborted:
INFO: Elapsed time: 0.459s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded, 0 targets configured)
oazizi000
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Upgrade rules scala and rules_meta
Relevant Issues: #2282
Type of change: /kind cleanup
Test Plan: Build succeeds