Create vizier and cloud cert-manager compatible secrets#2391
Merged
ddelnano merged 3 commits intoJun 22, 2026
Merged
Conversation
…secret Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
vihangm
approved these changes
Jun 22, 2026
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Create vizier and cloud cert-manager compatible secrets
Pixie's certificate management predates cert-manager becoming the definitive method for managing k8s certs. As a result, Pixie's certificates are created in an incompatible way to how cert-manager creates its TLS secrets -- Pixie's are of type generic and bundle client and server certs while cert-manager uses the tls secret type and only can store a single CA, key and cert file.
This PR updates Pixie's certificate management to create the existing generic secret alongside two tls type secrets.
Future PRs will move the consumers of these secrets to use the newer cert-manager compatible equivalents
Relevant Issues: N/A
Type of change: /kind cleanup
Test Plan: Used this as part of a larger change to deploy a cloud with cert-manager service tls certs
Changelog Message: Update Pixie's vizier and cloud certificate management to create cert-manager compatible kubernetes secrets