Skip to content

add pixie.walk#428

Merged
heyLu merged 1 commit intopixie-lang:masterfrom
mpenet:feature/walk
Nov 6, 2015
Merged

add pixie.walk#428
heyLu merged 1 commit intopixie-lang:masterfrom
mpenet:feature/walk

Conversation

@mpenet
Copy link
Copy Markdown
Contributor

@mpenet mpenet commented Nov 3, 2015

It's very similar to clojure.walk but uses transients when possible, and is extensible via a protocol.

@thomasmulvaney
Copy link
Copy Markdown
Member

I've restarted the build as it looks like pulling down deps failed.

@mpenet
Copy link
Copy Markdown
Contributor Author

mpenet commented Nov 3, 2015

yep, the pypy archive is not available https://bitbucket.org/pypy/pypy/get/default.tar.bz2 returns an http 500 at the moment.

@mpenet
Copy link
Copy Markdown
Contributor Author

mpenet commented Nov 3, 2015

I forgot to mention, this API doesn't include the "outer" fn parameter from the clojure equivalent, I never really understood why they baked in this fn, as you can just call it on the result returned by a walk yourself and seems to make things more confusing for little benefit.

Feel free to tell me if you think it's not ok.

@thomasmulvaney
Copy link
Copy Markdown
Member

I agree that the outer is probably not necessary. I like the choice of an IWalk protocol so walking can be extended in the future.

@mpenet
Copy link
Copy Markdown
Contributor Author

mpenet commented Nov 6, 2015

Do you need me to modify anything on this? (I need it for a toy project, but worst case I can use a local fork).

@thomasmulvaney
Copy link
Copy Markdown
Member

A quick squash would be nice, but otherwise this looks great. Thanks!

@mpenet
Copy link
Copy Markdown
Contributor Author

mpenet commented Nov 6, 2015

There you go! Squashed.

heyLu added a commit that referenced this pull request Nov 6, 2015
@heyLu heyLu merged commit bd33a3f into pixie-lang:master Nov 6, 2015
@heyLu
Copy link
Copy Markdown
Member

heyLu commented Nov 6, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants