Skip to content

parser.json : add write-string for generating JSON#467

Closed
jmglov wants to merge 1 commit intopixie-lang:masterfrom
jmglov:json-writer
Closed

parser.json : add write-string for generating JSON#467
jmglov wants to merge 1 commit intopixie-lang:masterfrom
jmglov:json-writer

Conversation

@jmglov
Copy link
Contributor

@jmglov jmglov commented Dec 7, 2015

No description provided.

@jmglov
Copy link
Contributor Author

jmglov commented Dec 7, 2015

This is probably not the best way to do JSON writing, but I figured I'd open a PR to get some feedback and get the ball rolling. I'll happily implement suggestions. :)

@thomasmulvaney
Copy link
Member

What do you think about using a protocol? It seems you are dispatching based on types most of the time so extending types to implement a IToJSON protocol maybe better than multimethods? Looks good though!

@jmglov
Copy link
Contributor Author

jmglov commented Dec 7, 2015

I'll give the protocol approach a go and see how that turns out. I was also thinking that if there's a pure-Clojure JSON implementation out there, maybe I can make Pixie compile it.

@jmglov jmglov closed this Dec 8, 2015
@jmglov jmglov deleted the json-writer branch December 8, 2015 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants