parser.json : add write-string for generating JSON#467
Closed
jmglov wants to merge 1 commit intopixie-lang:masterfrom
Closed
parser.json : add write-string for generating JSON#467jmglov wants to merge 1 commit intopixie-lang:masterfrom
jmglov wants to merge 1 commit intopixie-lang:masterfrom
Conversation
Contributor
Author
|
This is probably not the best way to do JSON writing, but I figured I'd open a PR to get some feedback and get the ball rolling. I'll happily implement suggestions. :) |
Member
|
What do you think about using a protocol? It seems you are dispatching based on types most of the time so extending types to implement a |
Contributor
Author
|
I'll give the protocol approach a go and see how that turns out. I was also thinking that if there's a pure-Clojure JSON implementation out there, maybe I can make Pixie compile it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.