Change calls to throw to vector instead of string#531
Merged
heyLu merged 1 commit intopixie-lang:masterfrom Jun 9, 2017
egregius313:patch-2
Merged
Change calls to throw to vector instead of string#531heyLu merged 1 commit intopixie-lang:masterfrom egregius313:patch-2
heyLu merged 1 commit intopixie-lang:masterfrom
egregius313:patch-2
Conversation
Calls to throw previously used strings, which is not a valid way to call throw (Thus raising an exception raised a completely different exception). Changed all calls to use vectors instead.
Member
|
This looks good, but I'm not sure about the custom exceptions. What do other languages do here? |
Member
|
Java has some file exceptions which subclass IOException. It certainly is nice to be handle exceptions on a case by case basis. |
thomasmulvaney
approved these changes
Jun 8, 2017
Member
|
Thanks @egregius313! ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calls to throw previously used strings, which is not a valid way to call throw (Thus raising an exception raised a completely different exception). Changed all calls to use vectors instead.