Docs: note accepted gap for enabled input value inside hidden wrapper#184
Merged
Conversation
Pre-#176, an enabled `<input value="…">` inside a CSS-hidden wrapper was caught by `hidden-text-strip`'s wrapper detach. After #176 nothing covers it. Document as accepted in `attribute-injection-sanitize`'s docstring — closing it cleanly would require computed-style checks inside the rule's attribute-driven watcher. Audit context: #179. Other gaps from that audit are tracked as #182 (missing ARIA attributes) and #183 (`input[type="hidden"][value]`). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![unblocked[bot]](https://avatars.githubusercontent.com/in/166219?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Doc-only follow-up to the #179 audit of
INJECTION_PATTERNScoverage after #176. Adds a paragraph toattribute-injection-sanitize's docstring describing the one accepted gap: an enabled<input value="…">sitting inside a CSS-hidden wrapper is no longer scrubbed (pre-#176,hidden-text-strip's wrapper detach took it).The same asymmetry as the existing
input[disabled][value]case applies (user can't see or edit), but closing it would need a computed-style check at scrub time, which conflicts with the rule's lightweight attribute-driven watcher. Documented as accepted; trigger surface is narrow.The other two audit gaps are tracked as separate issues:
CANDIDATE_ATTRIBUTESto coveraria-roledescription,aria-placeholder,aria-valuetext,aria-keyshortcutsvalueoninput[type="hidden"]Test plan
bun run checkinextension/clean