Ratchet unicorn/prefer-minimal-ternary to error#290
Merged
Conversation
From #279. Two of three sites factor the common part out of the ternary; the third can't and carries a scoped disable: - log.ts: `cond ? console.warn : cond2 ? console.error : console.log` → `console[cond ? "warn" : cond2 ? "error" : "log"]`. - page-world-hook.ts: `target ? register() : unregister()` → `(target ? register : unregister)()`. - confirmshame-sanitize.ts: keeps the ternary with a scoped disable — factoring `(cond ? f : g)(element)` widens the arg past the `instanceof` narrowing `rewriteInput` needs, and an `if`/`else` would trip `prefer-ternary`. Rule reverts to its unicorn/recommended default (error). Refs #279 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![unblocked[bot]](https://avatars.githubusercontent.com/in/166219?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #279. Two of the three sites factor the common part out of the ternary; the third keeps it with a scoped disable.
Changes
log.ts—cond ? console.warn : cond2 ? console.error : console.log→console[cond ? "warn" : cond2 ? "error" : "log"](the varying part is the method name).page-world-hook.ts—await (target ? register() : unregister())→await (target ? register : unregister)()(factor out the call).confirmshame-sanitize.ts— scoped disable. Factoring(element instanceof HTMLInputElement ? rewriteInput : rewriteButtonLike)(element)widens the argument back toElementand loses the narrowingrewriteInputrequires (typecheck error), while anif/elsewould tripunicorn/prefer-ternary. The ternary stays, with a rationale comment + inline disable.eslint.config.js— removed from the warn list → reverts to unicorn/recommended default (error).Verification
bun run checkexit 0 (rule errors; 0 violations;no-unused-disableclean)bun run typecheckcleanbun run test— 2059/2059 passRefs #279