Disable unicorn/max-nested-calls#294
Merged
Merged
Conversation
From #279. The call-depth cap (max 3) fires only on the two places this repo nests deeply on purpose, both of which read better nested than split into temporaries: - zod schema builders, e.g. `z.record(z.string(), z.union([z.string(), z.number()]))` - fast-check generators in property tests, e.g. `fc.array(fc.tuple(fc.nat(20), fc.integer({ min: 1, max: 20 })))` No path to `error` without contorting idiomatic builder/combinator code, so turn it off rather than leave standing warnings. Refs #279 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![unblocked[bot]](https://avatars.githubusercontent.com/in/166219?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #279. The call-depth cap (max 3) fires only on the two patterns this repo nests deeply on purpose, both of which read better nested than split into temporaries — so it's turned off rather than left as standing warnings (same call as the other ill-fitting rules in #287/#288).
Why off
All 16 hits are one of:
z.record(z.string(), z.union([z.string(), z.number()]))inmessage-schemas.ts. Splitting these into intermediate schema consts is more awkward than the inline builder.fc.array(fc.tuple(fc.nat(20), fc.integer({ min: 1, max: 20 })))etc. Deeply-nested combinators are the idiomatic, readable form.Neither has a clean path to
error. Disabled with a rationale comment alongside the other rules that don't fit this codebase.Change
eslint.config.js:max-nested-callswarn→off.Verification
bun run checkexit 0 (no violations)Refs #279