Add names to load parsers#13
Closed
UlyssesZh wants to merge 1 commit intopixijs-userland:mainfrom
Closed
Conversation
|
@UlyssesZh your PR just pointed me in the right direction. I stumbled over the load naming issue today and I was very suprised that not all parsers were available as in "normal" PIXI. My suggestion would be to stick to the original names so JS code will be compatible with both version: Really appreciate your inspection and work on that - thanks! |
Contributor
Author
Good suggestion, but there are possible counterarguments to this. Let's wait for opinions from other contributors or project owners. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is a fair enough change? It is simple enough, so I did not open an issue but opened a pull request directly.
Sometimes I need to specify the load parser explicitly when using
Assets.load, but it is difficult in Node.js because those extension load parsers in@pixi/nodedo not have names. This pull request fixes this problem.