Skip to content

icon.ymlがIcons 2.0も生成するようにする#883

Merged
mimokmt merged 22 commits intobeta/5-8-0from
feat/icon-workflow
Apr 7, 2026
Merged

icon.ymlがIcons 2.0も生成するようにする#883
mimokmt merged 22 commits intobeta/5-8-0from
feat/icon-workflow

Conversation

@mimokmt
Copy link
Copy Markdown
Contributor

@mimokmt mimokmt commented Mar 23, 2026

やったこと

  • Icons 2.0の生成フローを追加しました
  • Icons 1.0に対してもSVGOを利用したもの、CSSを利用したもの、Data URIの生成フローを追加しました
  • pullrequest-cliを拡張して、複数のディレクトリを対象にとれるようにしました
    • packages/iconspackages/icon-files 両方の差分を検出するための変更です
    • packages/ を対象に広げると意図していない差分を含んだPull Requestが作成されたら怖いと思って、pullrequest-cliを修正することにしました。
  • CodeQLにめちゃくちゃ怒られるので別でリファクタを入れています

動作確認環境

チェックリスト

不要なチェック項目は消して構いません

  • 破壊的変更がある場合には、対象のパッケージのメジャーバージョンが上がっていることを確認した
  • 追加したコンポーネントが index.ts から再 export されている
  • README やドキュメントに影響があることを確認した

@mimokmt mimokmt self-assigned this Mar 23, 2026
@mimokmt mimokmt added the patch label Mar 23, 2026
@mimokmt mimokmt temporarily deployed to preview-channel March 23, 2026 09:44 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2026

Size Change: +2.15 kB (+0.57%)

Total Size: 378 kB

📦 View Changed
Filename Size Change
packages/icons-cli/dist/index.js 22.5 kB +2.15 kB (+10.54%) ⚠️
ℹ️ View Unchanged
Filename Size
packages/foundation/dist/index.cjs 801 B
packages/foundation/dist/index.d.ts 3.56 kB
packages/foundation/dist/index.js 703 B
packages/icons/dist/index.cjs 9.97 kB
packages/icons/dist/index.d.ts 2.5 kB
packages/icons/dist/index.js 8.72 kB
packages/react-sandbox/dist/_lib/compat.d.ts 427 B
packages/react-sandbox/dist/_lib/ComponentAbstraction.d.ts 967 B
packages/react-sandbox/dist/components/Carousel/index.d.ts 1.38 kB
packages/react-sandbox/dist/components/CarouselButton/index.d.ts 515 B
packages/react-sandbox/dist/components/Filter/index.d.ts 1.05 kB
packages/react-sandbox/dist/components/HintText/index.d.ts 386 B
packages/react-sandbox/dist/components/icons/Base.d.ts 762 B
packages/react-sandbox/dist/components/icons/DotsIcon.d.ts 226 B
packages/react-sandbox/dist/components/icons/InfoIcon.d.ts 115 B
packages/react-sandbox/dist/components/icons/NextIcon.d.ts 309 B
packages/react-sandbox/dist/components/icons/WedgeIcon.d.ts 345 B
packages/react-sandbox/dist/components/Layout/index.d.ts 2.18 kB
packages/react-sandbox/dist/components/LeftMenu/index.d.ts 438 B
packages/react-sandbox/dist/components/MenuListItem/index.d.ts 1.91 kB
packages/react-sandbox/dist/components/Pager/index.d.ts 557 B
packages/react-sandbox/dist/components/SwitchCheckbox/index.d.ts 340 B
packages/react-sandbox/dist/components/TextEllipsis/helper.d.ts 230 B
packages/react-sandbox/dist/components/TextEllipsis/index.d.ts 381 B
packages/react-sandbox/dist/components/WithIcon/index.d.ts 1.07 kB
packages/react-sandbox/dist/foundation/constants.d.ts 208 B
packages/react-sandbox/dist/foundation/hooks.d.ts 1.04 kB
packages/react-sandbox/dist/foundation/support.d.ts 131 B
packages/react-sandbox/dist/foundation/utils.d.ts 613 B
packages/react-sandbox/dist/hooks/index.d.ts 148 B
packages/react-sandbox/dist/index.cjs 33.2 kB
packages/react-sandbox/dist/index.d.ts 1.38 kB
packages/react-sandbox/dist/index.js 31.1 kB
packages/react-sandbox/dist/misc/storybook-helper.d.ts 343 B
packages/react-sandbox/dist/styled.d.ts 12.3 kB
packages/react/dist/_lib/compat.d.ts 1.19 kB
packages/react/dist/_lib/createDivComponent.d.ts 614 B
packages/react/dist/_lib/index.d.ts 1.02 kB
packages/react/dist/_lib/useClassNames.d.ts 192 B
packages/react/dist/_lib/useForwardedRef.d.ts 169 B
packages/react/dist/components/Button/index.d.ts 766 B
packages/react/dist/components/Button/styledButtonTypeTest.d.d.ts 63 B
packages/react/dist/components/Checkbox/CheckboxInput/index.d.ts 628 B
packages/react/dist/components/Checkbox/CheckboxWithLabel.d.ts 271 B
packages/react/dist/components/Checkbox/index.d.ts 592 B
packages/react/dist/components/Clickable/index.d.ts 681 B
packages/react/dist/components/DropdownSelector/Divider/index.d.ts 133 B
packages/react/dist/components/DropdownSelector/DropdownMenuItem/index.d.ts 441 B
packages/react/dist/components/DropdownSelector/DropdownPopover.d.ts 514 B
packages/react/dist/components/DropdownSelector/index.d.ts 877 B
packages/react/dist/components/DropdownSelector/ListItem/index.d.ts 485 B
packages/react/dist/components/DropdownSelector/MenuItem/index.d.ts 639 B
packages/react/dist/components/DropdownSelector/MenuItem/internals/handleFocusByKeyBoard.d.ts 373 B
packages/react/dist/components/DropdownSelector/MenuItem/internals/useMenuItemHandleKeyDown.d.ts 480 B
packages/react/dist/components/DropdownSelector/MenuItemGroup/index.d.ts 442 B
packages/react/dist/components/DropdownSelector/MenuList/index.d.ts 568 B
packages/react/dist/components/DropdownSelector/MenuList/internals/getValuesRecursive.d.ts 412 B
packages/react/dist/components/DropdownSelector/MenuList/MenuListContext.d.ts 412 B
packages/react/dist/components/DropdownSelector/Popover/index.d.ts 1.03 kB
packages/react/dist/components/DropdownSelector/Popover/usePreventScroll.d.ts 159 B
packages/react/dist/components/DropdownSelector/utils/findPreviewRecursive.d.ts 411 B
packages/react/dist/components/FieldLabel/index.d.ts 492 B
packages/react/dist/components/HintText/index.d.ts 382 B
packages/react/dist/components/Icon/index.d.ts 498 B
packages/react/dist/components/IconButton/index.d.ts 639 B
packages/react/dist/components/LoadingSpinner/index.d.ts 678 B
packages/react/dist/components/Modal/Dialog/index.d.ts 373 B
packages/react/dist/components/Modal/index.d.ts 2.13 kB
packages/react/dist/components/Modal/ModalBackgroundContext.d.ts 231 B
packages/react/dist/components/Modal/ModalPlumbing.d.ts 1.75 kB
packages/react/dist/components/Modal/useCustomModalOverlay.d.ts 797 B
packages/react/dist/components/MultiSelect/context.d.ts 394 B
packages/react/dist/components/MultiSelect/index.d.ts 1.25 kB
packages/react/dist/components/Pagination/helper.d.ts 238 B
packages/react/dist/components/Pagination/index.d.ts 2.01 kB
packages/react/dist/components/Pagination/PaginationContext.d.ts 881 B
packages/react/dist/components/Radio/index.d.ts 482 B
packages/react/dist/components/Radio/RadioGroup/index.d.ts 733 B
packages/react/dist/components/Radio/RadioGroupContext.d.ts 339 B
packages/react/dist/components/Radio/RadioInput/index.d.ts 584 B
packages/react/dist/components/SegmentedControl/index.d.ts 836 B
packages/react/dist/components/SegmentedControl/RadioGroupContext.d.ts 362 B
packages/react/dist/components/Switch/index.d.ts 452 B
packages/react/dist/components/Switch/SwitchInput/index.d.ts 482 B
packages/react/dist/components/Switch/SwitchWithLabel.d.ts 272 B
packages/react/dist/components/TagItem/index.d.ts 716 B
packages/react/dist/components/TextArea/index.d.ts 1.12 kB
packages/react/dist/components/TextEllipsis/helper.d.ts 350 B
packages/react/dist/components/TextEllipsis/index.d.ts 924 B
packages/react/dist/components/TextField/AssistiveText/index.d.ts 592 B
packages/react/dist/components/TextField/index.d.ts 1.25 kB
packages/react/dist/components/TextField/useFocusWithClick.d.ts 256 B
packages/react/dist/core/CharcoalProvider.d.ts 270 B
packages/react/dist/core/OverlayProvider.d.ts 101 B
packages/react/dist/core/SetThemeScript.d.ts 890 B
packages/react/dist/core/SSRProvider.d.ts 335 B
packages/react/dist/core/themeHelper.d.ts 2.05 kB
packages/react/dist/index.cjs 33.6 kB
packages/react/dist/index.d.ts 2.67 kB
packages/react/dist/index.js 30.4 kB
packages/styled/dist/addThemeUtils.story.d.ts 330 B
packages/styled/dist/builders/border.d.ts 685 B
packages/styled/dist/builders/borderRadius.d.ts 440 B
packages/styled/dist/builders/colors.d.ts 1.28 kB
packages/styled/dist/builders/elementEffect.d.ts 533 B
packages/styled/dist/builders/o.d.ts 5.91 kB
packages/styled/dist/builders/outline.d.ts 638 B
packages/styled/dist/builders/size.d.ts 1.19 kB
packages/styled/dist/builders/spacing.d.ts 1.12 kB
packages/styled/dist/builders/transition.d.ts 287 B
packages/styled/dist/builders/typography.d.ts 624 B
packages/styled/dist/defineThemeVariables.test.d.ts 66 B
packages/styled/dist/factories/lib.d.ts 3.96 kB
packages/styled/dist/index.cjs 11.8 kB
packages/styled/dist/index.d.ts 6.9 kB
packages/styled/dist/index.js 10.3 kB
packages/styled/dist/index.test.d.ts 204 B
packages/styled/dist/internals/index.d.ts 1.6 kB
packages/styled/dist/storyHelper.d.ts 386 B
packages/styled/dist/styles/assertiveRingCss.d.ts 141 B
packages/styled/dist/styles/disabledCss.d.ts 131 B
packages/styled/dist/styles/focusVisibleFocusRingCss.d.ts 318 B
packages/styled/dist/TokenInjector.d.ts 533 B
packages/styled/dist/util.d.ts 4.24 kB
packages/styled/dist/utils/addThemeUtils.d.ts 383 B
packages/styled/dist/utils/CharcoalStyledTheme.d.ts 1.43 kB
packages/styled/dist/utils/gap.d.ts 473 B
packages/styled/dist/utils/helpers/pxIfNum.d.ts 99 B
packages/styled/dist/utils/helpers/SpacingType.d.ts 137 B
packages/styled/dist/utils/margin.d.ts 905 B
packages/styled/dist/utils/padding.d.ts 935 B
packages/styled/dist/utils/typographyCss.d.ts 306 B
packages/tailwind-config/dist/index.d.ts 977 B
packages/tailwind-config/dist/index.js 17.8 kB
packages/tailwind-diff/dist/commands/check.d.ts 296 B
packages/tailwind-diff/dist/commands/check.js 4.35 kB
packages/tailwind-diff/dist/commands/dump.d.ts 185 B
packages/tailwind-diff/dist/commands/dump.js 1.24 kB
packages/tailwind-diff/dist/defer.d.ts 164 B
packages/tailwind-diff/dist/defer.js 762 B
packages/tailwind-diff/dist/index.d.ts 46 B
packages/tailwind-diff/dist/index.js 1.84 kB
packages/tailwind-diff/dist/packageManager.d.ts 323 B
packages/tailwind-diff/dist/packageManager.js 1.81 kB
packages/tailwind-diff/dist/style.d.ts 436 B
packages/tailwind-diff/dist/style.js 2.6 kB
packages/tailwind-diff/dist/withPackages.d.ts 464 B
packages/tailwind-diff/dist/withPackages.js 3.34 kB
packages/theme/dist/index.cjs 3.27 kB
packages/theme/dist/index.d.ts 3.72 kB
packages/theme/dist/index.js 3.17 kB
packages/theme/dist/unstable-css/_variables_dark.css.d.ts 26 B
packages/theme/dist/unstable-css/_variables_light.css.d.ts 26 B
packages/theme/dist/unstable-token-object/index.cjs 4.28 kB
packages/theme/dist/unstable-token-object/index.d.ts 1.63 kB
packages/theme/dist/unstable-token-object/index.js 3.04 kB
packages/token-cli/dist/index.js 6.58 kB
packages/utils/dist/index.cjs 2.6 kB
packages/utils/dist/index.d.ts 3.27 kB
packages/utils/dist/index.js 2.38 kB

compressed-size-action

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2026

Visit the preview URL for this PR (updated for commit 70c9e8f):

https://pixiv-charcoal-web--pr883-feat-icon-workflow-8ryugbf6.web.app

(expires Tue, 14 Apr 2026 05:24:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 314b26d3adca98a761c7e4d9922ebb206ff024a0

@mimokmt mimokmt temporarily deployed to preview-channel March 23, 2026 09:52 — with GitHub Actions Inactive
@mimokmt mimokmt force-pushed the feat/icon-workflow branch from 1314fb8 to 4e888dc Compare March 23, 2026 10:07
@mimokmt mimokmt temporarily deployed to preview-channel March 23, 2026 10:07 — with GitHub Actions Inactive
@mimokmt mimokmt temporarily deployed to preview-channel March 23, 2026 10:11 — with GitHub Actions Inactive
@mimokmt mimokmt temporarily deployed to preview-channel March 23, 2026 11:11 — with GitHub Actions Inactive
env:
FIGMA_FILE_URL: ${{ secrets.FIGMA_FILE_URL }}
FIGMA_TOKEN: ${{ secrets.FIGMA_TOKEN }}
FIGMA_TOKEN: ${{ secrets.FIGMA_TOKEN_LIMITED }}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一時的に新しいトークンに変えてる、新しいmimoアカウントのトークンだとrate limitがhighになっていて大量のリクエストを送りやすい
でも、 FIGMA_TOKEN でも1度実行に成功しているので1ヶ月に1回程度なら耐えるかも

@mimokmt mimokmt marked this pull request as ready for review March 24, 2026 03:46
@mimokmt mimokmt requested review from naporin0624 and yue4u March 24, 2026 03:46
@mimokmt mimokmt force-pushed the feat/icon-workflow branch from 2308746 to c9ed50c Compare March 27, 2026 06:01
@mimokmt mimokmt temporarily deployed to preview-channel March 27, 2026 06:01 — with GitHub Actions Inactive
@mimokmt mimokmt temporarily deployed to preview-channel March 27, 2026 06:19 — with GitHub Actions Inactive
@mimokmt mimokmt force-pushed the feat/icon-workflow branch from 30fc6d7 to 87aba61 Compare March 27, 2026 06:27
@mimokmt mimokmt temporarily deployed to preview-channel March 27, 2026 06:27 — with GitHub Actions Inactive
@mimokmt mimokmt temporarily deployed to preview-channel March 27, 2026 08:38 — with GitHub Actions Inactive
@mimokmt mimokmt force-pushed the feat/icon-workflow branch from d78c52e to f246fab Compare March 27, 2026 08:56
@mimokmt mimokmt temporarily deployed to preview-channel March 27, 2026 08:56 — with GitHub Actions Inactive
@mimokmt mimokmt temporarily deployed to preview-channel March 27, 2026 10:12 — with GitHub Actions Inactive
Copy link
Copy Markdown
Member

@naporin0624 naporin0624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう

@mimokmt mimokmt force-pushed the feat/icon-workflow branch from faa1553 to 41b6672 Compare March 31, 2026 01:15
@mimokmt mimokmt temporarily deployed to preview-channel March 31, 2026 01:15 — with GitHub Actions Inactive
@mimokmt mimokmt temporarily deployed to preview-channel April 3, 2026 08:01 — with GitHub Actions Inactive
@mimokmt mimokmt temporarily deployed to preview-channel April 3, 2026 08:07 — with GitHub Actions Inactive
@mimokmt mimokmt temporarily deployed to preview-channel April 3, 2026 08:46 — with GitHub Actions Inactive
@mimokmt mimokmt force-pushed the feat/icon-workflow branch from 445af09 to 581613b Compare April 7, 2026 02:07
@mimokmt mimokmt temporarily deployed to preview-channel April 7, 2026 02:07 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Dependency Review

The following issues were found:

  • ❌ 1 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ✅ 0 package(s) with unknown licenses.

View full job summary

@mimokmt mimokmt temporarily deployed to preview-channel April 7, 2026 02:10 — with GitHub Actions Inactive
@mimokmt mimokmt changed the base branch from main to beta/5-8-0 April 7, 2026 06:14
@mimokmt mimokmt merged commit 0ca7759 into beta/5-8-0 Apr 7, 2026
20 checks passed
@mimokmt mimokmt mentioned this pull request Apr 7, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants