Performance tuning review#3
Merged
Merged
Conversation
Top-level function declarations in a .cfm template are now visible from anywhere in the template, regardless of textual order. Each top-level FunctionDecl is emitted once at program start (so forward references resolve) and re-emitted at its original textual position so the closure-env sync still snapshots the locals visible at decl time, preserving existing scope-capture semantics. Fixes the Taffy dashboard `getDocUrl is undefined` failure.
`<cfinclude template="../foo.cfm">` previously failed with `Cannot read 'src/dir/../foo.cfm'` because the resolver joined paths without collapsing `..` and `.` segments. Adds a lexical `normalize_path` (no filesystem I/O, no symlink resolution) wired into both Include and IncludeDynamic. Fixes the Taffy `examples/api_empty/` 500.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.