forked from SmartTeachCN/pycses
-
Notifications
You must be signed in to change notification settings - Fork 0
sync cseslib4py #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4ecef65
add converter for Lesson.start_time/end_time
MacroMeng 043637e
remove null line at last of errors.py
MacroMeng e2f9e42
add validator and convertor for Lesson.start_time/end_time
MacroMeng c0b293d
add logger support
MacroMeng d17b4b6
add logs in parser & generator part 1
MacroMeng 1597c20
remove logs in functions of utils.py
MacroMeng 0adced3
disable alias of YAML and add serializer for Lesson.start_time / end_…
MacroMeng 860bb81
fix Lesson constructing and add function to_file() & __eq__
MacroMeng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,4 +11,3 @@ class ParseError(CSESError): | |
|
|
||
| class VersionError(CSESError): | ||
| """解析 CSES 课程文件时,版本号错误抛出的异常。""" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: 如果 fp 是一个没有目录的文件名,os.makedirs 可能会失败。
在调用 os.makedirs 之前检查 os.path.dirname(fp) 是否非空,以避免当 fp 只是一个文件名时出现错误。
Original comment in English
issue: os.makedirs may fail if fp is a filename without a directory.
Check if os.path.dirname(fp) is non-empty before calling os.makedirs to avoid errors when fp is just a filename.