Fix processing peer reflexive ICE candidates with empty checklist#4731
Merged
sauwming merged 1 commit intopjsip:masterfrom Jan 9, 2026
Merged
Fix processing peer reflexive ICE candidates with empty checklist#4731sauwming merged 1 commit intopjsip:masterfrom
sauwming merged 1 commit intopjsip:masterfrom
Conversation
When we learn of a peer-reflexive ICE candidate through STUN binding requests, try to match the local candidate to the list oof local candidates rather than the checklist, since it might be empty. The checklist can be empty when using trickle ICE for example, if remote cancidates haven't been signalled yet.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug in ICE session handling where processing peer-reflexive candidates would fail when the checklist is empty, which commonly occurs in trickle ICE scenarios where remote candidates haven't been signaled yet.
Key Changes:
- Modified local candidate selection to search the
ice->lcandarray instead of the checklist (ice->clist.checks) - Improved the selection algorithm to explicitly choose the highest priority matching candidate
- Removed obsolete commented-out code and updated the explanatory comment
sauwming
approved these changes
Jan 9, 2026
Member
|
Looks okay to me, but @nanangizz should be more expert in this area |
nanangizz
approved these changes
Jan 9, 2026
wosrediinanatour
pushed a commit
to wosrediinanatour/pjproject
that referenced
this pull request
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we learn of a peer-reflexive ICE candidate through STUN binding
requests, try to match the local candidate to the list oof local
candidates rather than the checklist, since it might be empty.
The checklist can be empty when using trickle ICE for example, if remote
cancidates haven't been signalled yet.