Skip to content

Fix regex for uploading#106

Merged
jhheider merged 1 commit intopkgxdev:mainfrom
uesyn:fix-upload-regex
May 4, 2023
Merged

Fix regex for uploading#106
jhheider merged 1 commit intopkgxdev:mainfrom
uesyn:fix-upload-regex

Conversation

@uesyn
Copy link
Copy Markdown
Contributor

@uesyn uesyn commented May 4, 2023

Fix wrong regex, and add the tests.
ref: #101 (comment)
However, I don't understand x86-64 is succeeded to be uploaded...

@uesyn
Copy link
Copy Markdown
Contributor Author

uesyn commented May 4, 2023

local tests is passed.

tests
$ deno task test
Task test deno test tests
running 1 test from ./tests/unit/useCache.test.ts
decode ...
  type == bottle, arch == x86-64, platform == linux, version == 1 ... ok (5ms)
  type == bottle, arch == x86-64, platform == darwin, version == 1 ... ok (4ms)
  type == bottle, arch == aarch64, platform == linux, version == 1 ... ok (4ms)
  type == bottle, arch == aarch64, platform == darwin, version == 1 ... ok (4ms)
  type == bottle, arch == x86-64, platform == linux, version == 9e ... ok (4ms)
  type == bottle, arch == x86-64, platform == darwin, version == 9e ... ok (4ms)
  type == bottle, arch == aarch64, platform == linux, version == 9e ... ok (4ms)
  type == bottle, arch == aarch64, platform == darwin, version == 9e ... ok (4ms)
  type == bottle, arch == x86-64, platform == linux, version == 1.2 ... ok (4ms)
  type == bottle, arch == x86-64, platform == darwin, version == 1.2 ... ok (4ms)
  type == bottle, arch == aarch64, platform == linux, version == 1.2 ... ok (4ms)
  type == bottle, arch == aarch64, platform == darwin, version == 1.2 ... ok (4ms)
  type == bottle, arch == x86-64, platform == linux, version == 3.3a ... ok (4ms)
  type == bottle, arch == x86-64, platform == darwin, version == 3.3a ... ok (4ms)
  type == bottle, arch == aarch64, platform == linux, version == 3.3a ... ok (4ms)
  type == bottle, arch == aarch64, platform == darwin, version == 3.3a ... ok (3ms)
  type == bottle, arch == x86-64, platform == linux, version == 1.2.3 ... ok (3ms)
  type == bottle, arch == x86-64, platform == darwin, version == 1.2.3 ... ok (4ms)
  type == bottle, arch == aarch64, platform == linux, version == 1.2.3 ... ok (4ms)
  type == bottle, arch == aarch64, platform == darwin, version == 1.2.3 ... ok (4ms)
  type == bottle, arch == x86-64, platform == linux, version == 1.2.3a ... ok (4ms)
  type == bottle, arch == x86-64, platform == darwin, version == 1.2.3a ... ok (4ms)
  type == bottle, arch == aarch64, platform == linux, version == 1.2.3a ... ok (4ms)
  type == bottle, arch == aarch64, platform == darwin, version == 1.2.3a ... ok (4ms)
  type == bottle, arch == x86-64, platform == linux, version == 1.2.3.4 ... ok (4ms)
  type == bottle, arch == x86-64, platform == darwin, version == 1.2.3.4 ... ok (4ms)
  type == bottle, arch == aarch64, platform == linux, version == 1.2.3.4 ... ok (4ms)
  type == bottle, arch == aarch64, platform == darwin, version == 1.2.3.4 ... ok (4ms)
  type == bottle, arch == x86-64, platform == linux, version == 1.2.3.4a ... ok (4ms)
  type == bottle, arch == x86-64, platform == darwin, version == 1.2.3.4a ... ok (4ms)
  type == bottle, arch == aarch64, platform == linux, version == 1.2.3.4a ... ok (4ms)
  type == bottle, arch == aarch64, platform == darwin, version == 1.2.3.4a ... ok (4ms)
  type == src, version == 1 ... ok (4ms)
  type == src, version == 9e ... ok (3ms)
  type == src, version == 1.2 ... ok (4ms)
  type == src, version == 3.3a ... ok (4ms)
  type == src, version == 1.2.3 ... ok (4ms)
  type == src, version == 1.2.3a ... ok (3ms)
  type == src, version == 1.2.3.4 ... ok (4ms)
  type == src, version == 1.2.3.4a ... ok (4ms)
decode ... ok (172ms)

ok | 1 passed (40 steps) | 0 failed (199ms)

@jhheider
Copy link
Copy Markdown
Contributor

jhheider commented May 4, 2023

Looks good. Adding it to the unit tests always a great choice.

@jhheider jhheider merged commit 770201c into pkgxdev:main May 4, 2023
@uesyn uesyn deleted the fix-upload-regex branch May 4, 2023 19:12
@jhheider
Copy link
Copy Markdown
Contributor

jhheider commented May 4, 2023

confirmed fixed: https://github.com/teaxyz/pantry/actions/runs/4876470207

great work, @uesyn !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants