fix(fixup): verify yaml key for skip: fix-patchelf and fix-machos

[tsirysndr]

fixes pkgxdev/pantry#3724

[jhheider]

Definitely need to make all the formatting changes in a different branch if desired.

We should probably have a yaml key for skip-patchelf and skip-fix-machos.

[tsirysndr]

I've added a check of the new yaml keys skip-patchelf and skip-fix-machos

[jhheider]

I love it. Moves it to the yaml. Any concerns, @mxcl?

[mxcl]

Why are we skipping? I prefer to fix the problem than work around it. If possible.

[jhheider]

deno-built binaries can't have fix-elf.ts run on them, or it breaks the DATA segment look up, and they just become bloated deno binaries. it would let us generalize:

brewkit/share/brewkit/fix-elf.ts

Lines 26 to 34 in a9c140e

	const skip_rpaths = [
	"go.dev", // skipping because for some reason patchelf breaks the go binary resulting in the only output being: `Segmentation Fault`
	"pkgx.sh", // this causes pkgx to pass -E/--version (and everything else?) directly to deno, making it _too_ much of a wrapper.
	"render.com", // same as `pkgx.sh`
	]
	if (skip_rpaths.includes(installation.pkg.project)) {
	console.info(`skipping rpath fixes for ${installation.pkg.project}`)
	return
	}

and give us a path when similar issues are found in the fix-machos.rb side.

[mxcl]

Agreed, though I was looking for explanation for this pacakge? Does it use deno?

I think a more suitable syntax here would be skip: [fix-macho, fix-patchelf]

And we can do even better for v2 with some kind of composable build steps system.

[jhheider]

yup, deno. this is our third, but surely far from our last. your skip string | string[] is more forward looking, and i like it.

[mxcl]

I wonder if these other deno packages had the same problem as we did packaging for homebrew core?

[mxcl]

lgtm! many thanks for a great patch

[jhheider]

re: that test failure: I don't know where we're finding that pip tag. I think it must have been deleted, but the api is still serving it.

https://github.com/pypa/pip/tags

[mxcl]

Crossing fingers that the build failure is nothing to do with this since it seems impossible it was.