Merged
Conversation
Contributor
|
DX is idiomatic and good IMO |
mxcl
reviewed
Apr 16, 2023
| throw new Error() | ||
| })(match[0]) | ||
|
|
||
| // We'll handle dates > calver automatically. For now. |
Contributor
There was a problem hiding this comment.
possibly a nice feature for tags too…?
Contributor
Author
There was a problem hiding this comment.
I think allowing semver.parse to try the same string with .replaceAll("-", ".") in tolerant mode will probably fix more problems than it causes. Some repos have tags like project_3_1_22.
mxcl
approved these changes
Apr 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not sure about the DX here.
ca-certslooks like this: