Conversation
Contributor
Author
|
@jhheider does this accomplish what you wanted? |
Contributor
|
That's pretty good, except it requires a yaml read, even if the project name is found. A better solution probably checks the names on a pass, then does a pass reading yamls to check for provides/display-names. So you don't have to open up to over 600 files unless necessary. |
Contributor
Author
|
The method returns an array, because it should—there might be conflicts. I could add one that returns the first and then parallelizes a bit, need a use case where it's ok to do that tho.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #33