Skip to content

cairographics.org/pycairo#2760

Merged
jhheider merged 4 commits intopkgxdev:mainfrom
and-ri:new/cairographics.org/pycairo
Aug 8, 2023
Merged

cairographics.org/pycairo#2760
jhheider merged 4 commits intopkgxdev:mainfrom
and-ri:new/cairographics.org/pycairo

Conversation

@and-ri
Copy link
Copy Markdown
Contributor

@and-ri and-ri commented Aug 7, 2023

closes #514

@and-ri and-ri marked this pull request as ready for review August 7, 2023 18:31
Comment on lines +10 to +14
PYTHONPATH: "{{prefix}}/lib/python3.11/site-packages:$PYTHONPATH"
build:
dependencies:
freedesktop.org/pkg-config: '*'
python.org: ^3.11
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're going to lock the directory via PYTHONPATH, then I think you probably need to lock the version as well, to ~3.11. Possibly that could instead be worked around with symlinks? ln -s python{{version.marketing}} python{{version.major}}?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did with {{deps.python.org.version.marketing}}
So will it be ok?

cairographics.org: '*'
runtime:
env:
PYTHONPATH: "{{prefix}}/lib/python{{deps.python.org.version.marketing}}/site-packages:$PYTHONPATH"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this probably won't work. Since it doesn't have a runtime dep on python. So, we'd either have to hardcode it to 3 (which is probably what we need to do), or something else that probably won't work.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. I did not think about the fact that Python is not in runtime

@jhheider jhheider merged commit 47af95a into pkgxdev:main Aug 8, 2023
@and-ri and-ri deleted the new/cairographics.org/pycairo branch September 20, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

+py3cairo (52/548)

2 participants