Remove tolerant option from Semver#573
Merged
Merged
Conversation
PR Summary
|
Contributor
|
k i think this is safe. The main reason for being tolerant here before was we parsed versions out of junk like |
mxcl
approved these changes
May 9, 2023
Contributor
|
/cc @ABevier |
This was referenced May 9, 2023
|
Changes unknown |
Contributor
|
801 days. Solid, automated necroing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uploaded bottles versions are always checked with Semver with tolerant=true.
Therefore, CLI also has to accept SemVer objects with tolerant=true, I think it meens that tolerant option doesn't be needed.
This PR remove the tolerant option from SemVer.
I confirmed local tests are all passed and tmux=3.3a can be run.
test resulsts
tmux
fix: #572