Skip to content

Only read packages from action.yml that specifies version#691

Closed
gaggle wants to merge 1 commit intopkgxdev:mainfrom
gaggle:main
Closed

Only read packages from action.yml that specifies version#691
gaggle wants to merge 1 commit intopkgxdev:mainfrom
gaggle:main

Conversation

@gaggle
Copy link
Contributor

@gaggle gaggle commented Aug 19, 2023

Took a stab at fixing #690 by only parsing action.yml version if version exists.

Closes #690

@what-the-diff
Copy link

what-the-diff bot commented Aug 19, 2023

PR Summary

  • Enhanced Condition in Virtual Environment Utilization
    We've introduced a new condition in our environment setup process. This simply means we now have an improved way to include certain tools if specific conditions are met. This promises more flexibility in our deployment and architectural setup.

  • Added new test
    A new file named action.yml has been added to our test folder 'no-version'. This file will be instrumental in running certain test cases ensuring our application's ongoing stability and efficiency.

  • Additional Test Case
    An additional test case was included within our functional development environment test suite. It is designed to evaluate the processing of packages. Simply, this ensures on how well our application handles data packages even when they might not perfectly conform to expected formatting. This further improves our application stability and error-handling ability.

@gaggle
Copy link
Contributor Author

gaggle commented Aug 19, 2023

  • A second test case was added to the same file to test the tolerant parsing of .node-version details. This helps the application to handle discrepancies or issues while reading Node.js version information from the configuration file.

The summary is a cool feature, but it looks like it's off by one because this seems like it thinks #L167 is part of this change when it isn't. Oh well, off by one errors are one of the two hardest problems in computing after all :)

@gaggle
Copy link
Contributor Author

gaggle commented Aug 19, 2023

Force-pushed new commit that's signed

@gaggle
Copy link
Contributor Author

gaggle commented Sep 2, 2023

Anything I can do to move forward with this?

@mxcl mxcl force-pushed the main branch 24 times, most recently from b3290ec to b0c3eba Compare September 10, 2023 14:16
@mxcl mxcl closed this in ed51fe7 Sep 11, 2023
@mxcl
Copy link
Contributor

mxcl commented Sep 11, 2023

Thank you for this contribution and I apologize for not getting to it sooner. I was busy on v1 and couldn't be distracted. I have applied your patch separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error panic:invalid version: undefined when running tea -SE with un-versioned action.yml file present (w. PR to fix it)

2 participants