-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Run installed packages silently #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Summary
|
Contributor
Author
|
@what-the-diff is confused on this one. |
Member
|
We already prohibit the output if not run in a tty, which we did to handle this situation. Or at least we should… if not it's a regression. Do you have an example where we need to do this so we can study it. |
Contributor
Author
|
@mxcl thanks for the prompt response. Assuming $ tea install git
[...]
$ tea lazygit
2023/09/11 19:25:25 An error occurred! Please create an issue at: https://github.com/jesseduffield/lazygit/issues
*strconv.NumError strconv.ParseBool: parsing "\x1b[1K\x1b[0Gtea: resolving graph…\x1b[1K\x1b[0G\x1b[1A\x1b[0Jfalse": invalid syntax
/var/folders/y3/yr3bxsy95c3gfwwj61ytbp000000gq/T/4b5ecf61/pkg/app/app.go:55 (0x100a88ca0)
/var/folders/y3/yr3bxsy95c3gfwwj61ytbp000000gq/T/4b5ecf61/pkg/app/entry_point.go:154 (0x100a8a8cc)
/var/folders/y3/yr3bxsy95c3gfwwj61ytbp000000gq/T/4b5ecf61/main.go:23 (0x100a8c128)
/opt/go.dev/v1.20.7/src/runtime/internal/atomic/types.go:194 (0x100449f08)
/opt/go.dev/v1.20.7/src/runtime/asm_arm64.s:1172 (0x10047a624) |
Member
|
yeah my bad it regressed, will fix in alpha.2 |
mxcl
added a commit
that referenced
this pull request
Sep 11, 2023
mxcl
added a commit
that referenced
this pull request
Sep 11, 2023
mxcl
added a commit
that referenced
this pull request
Sep 11, 2023
mxcl
added a commit
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this would be preferable to the otherwise intrusive logging that may break certain programs or GUIs that expect clean output from tools like e.g. git. And since we can't really install a package without resolving it first, it'd be rather rare for logging to be useful when executing installed packages which have already been resolved.