Skip to content

Conversation

@davdroman
Copy link
Contributor

@davdroman davdroman commented Sep 11, 2023

I think this would be preferable to the otherwise intrusive logging that may break certain programs or GUIs that expect clean output from tools like e.g. git. And since we can't really install a package without resolving it first, it'd be rather rare for logging to be useful when executing installed packages which have already been resolved.

@what-the-diff
Copy link

what-the-diff bot commented Sep 11, 2023

PR Summary

  • Silent Install Function Update
    The modification in the install.ts file modifies the command that installs new packages through our application. Initially, while installing a package, some feedback was provided to the user during the process. With the updated command, the installation process is now run silently. That means, there will be a clean and distraction-free interface for the user until the installation is completed. This should improve user experience by eliminating potential clutter or unnecessary information during the installation.

@davdroman
Copy link
Contributor Author

davdroman commented Sep 11, 2023

@what-the-diff is confused on this one.

@mxcl
Copy link
Member

mxcl commented Sep 11, 2023

We already prohibit the output if not run in a tty, which we did to handle this situation. Or at least we should… if not it's a regression.

Do you have an example where we need to do this so we can study it.

@davdroman
Copy link
Contributor Author

davdroman commented Sep 11, 2023

@mxcl thanks for the prompt response.

Assuming ~/.local/bin is in your $PATH:

$ tea install git
[...]

$ tea lazygit
2023/09/11 19:25:25 An error occurred! Please create an issue at: https://github.com/jesseduffield/lazygit/issues

*strconv.NumError strconv.ParseBool: parsing "\x1b[1K\x1b[0Gtea: resolving graph…\x1b[1K\x1b[0G\x1b[1A\x1b[0Jfalse": invalid syntax
/var/folders/y3/yr3bxsy95c3gfwwj61ytbp000000gq/T/4b5ecf61/pkg/app/app.go:55 (0x100a88ca0)
/var/folders/y3/yr3bxsy95c3gfwwj61ytbp000000gq/T/4b5ecf61/pkg/app/entry_point.go:154 (0x100a8a8cc)
/var/folders/y3/yr3bxsy95c3gfwwj61ytbp000000gq/T/4b5ecf61/main.go:23 (0x100a8c128)
/opt/go.dev/v1.20.7/src/runtime/internal/atomic/types.go:194 (0x100449f08)
/opt/go.dev/v1.20.7/src/runtime/asm_arm64.s:1172 (0x10047a624)

@mxcl
Copy link
Member

mxcl commented Sep 11, 2023

yeah my bad it regressed, will fix in alpha.2

mxcl added a commit that referenced this pull request Sep 11, 2023
mxcl added a commit that referenced this pull request Sep 11, 2023
mxcl added a commit that referenced this pull request Sep 11, 2023
mxcl added a commit that referenced this pull request Sep 12, 2023
@mxcl mxcl closed this in a21069c Sep 12, 2023
@davdroman davdroman deleted the run-installed-bins-silently branch September 12, 2023 11:09
@davdroman davdroman restored the run-installed-bins-silently branch September 12, 2023 11:09
@davdroman davdroman deleted the run-installed-bins-silently branch September 12, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants