Skip to content

docs: correct admin role references across all documentation#31

Merged
pkmaster21 merged 1 commit intomainfrom
docs/fix-admin-role-accuracy
Apr 20, 2026
Merged

docs: correct admin role references across all documentation#31
pkmaster21 merged 1 commit intomainfrom
docs/fix-admin-role-accuracy

Conversation

@pkmaster21
Copy link
Copy Markdown
Owner

The memberRoleEnum in the Drizzle schema is ['owner', 'member'] — there is no admin role in v1. Several docs described admin as an existing, implemented role, which would be misleading to anyone reading the codebase.

What was wrong:

  • README and design-spec API tables listed DELETE /groups/:id/members/:memberId as requiring Admin+ — the actual middleware is requireOwner
  • The Roles & Permissions section in both README and design-spec described three roles (Owner, Admin, Member) with a full Admin capability matrix
  • docs/design-spec.md Data Model showed role (owner | admin | member) in the Member table description
  • DESIGN.md badges listed (owner, admin) as badge variants
  • The CI/CD section in design-spec said "On merge to main" triggers deployment — it's actually a v* tag

What was fixed:

  • All permission tables and auth columns updated to reflect the actual two-role model
  • Admin tier moved to a forward-reference to docs/FUTURE.md (which already correctly tracks it as a v2 feature)
  • Member table role enum corrected to owner | member
  • CI/CD trigger corrected to v* tag with the full deployment pipeline description
  • DESIGN.md badge variant corrected to (owner) only

docs/FUTURE.md and docs/TODO.md required no changes — both were already accurate.

The admin role is not implemented in v1 — memberRoleEnum is ['owner', 'member'].
Remove all references to admin as an existing role and update permission
descriptions, API table auth columns, and the roles section to reflect
the actual two-role model. Note admin as a planned v2 feature.
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying tabby with  Cloudflare Pages  Cloudflare Pages

Latest commit: 77ca2cb
Status:⚡️  Build in progress...

View logs

@pkmaster21 pkmaster21 merged commit 898e9a7 into main Apr 20, 2026
6 of 7 checks passed
@pkmaster21 pkmaster21 deleted the docs/fix-admin-role-accuracy branch April 20, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant