Skip to content

Make the library reentrant and thread-safe#21

Merged
pknotfound merged 1 commit intopknotfound:masterfrom
Mek101:reentrant
Sep 16, 2022
Merged

Make the library reentrant and thread-safe#21
pknotfound merged 1 commit intopknotfound:masterfrom
Mek101:reentrant

Conversation

@Mek101
Copy link
Copy Markdown
Contributor

@Mek101 Mek101 commented Sep 16, 2022

Moves non-immutable variables from class-scope to function scope, and makes the constants shared across all class instances.
This allows to make multiple concurrent calls to OpenGraphParser.parse without having different threads and coroutines interfere with each other

@pknotfound
Copy link
Copy Markdown
Owner

@Mek101
These changes were locally committed and were being tested out currently.
Your commit, however, includes moving constants to be shared across instances.

I shall include your changes.

Thank you for your contribution.

@pknotfound pknotfound closed this Sep 16, 2022
@pknotfound pknotfound reopened this Sep 16, 2022
@pknotfound pknotfound merged commit 7875da1 into pknotfound:master Sep 16, 2022
@Mek101 Mek101 deleted the reentrant branch September 16, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants