Clean up the SQL in markHavingUpdatedContent().#867
Merged
asmecher merged 1 commit intopkp:ojs-dev-2_4from Jun 20, 2016
ubermichael:gh-1533
Merged
Clean up the SQL in markHavingUpdatedContent().#867asmecher merged 1 commit intopkp:ojs-dev-2_4from ubermichael:gh-1533
asmecher merged 1 commit intopkp:ojs-dev-2_4from
ubermichael:gh-1533
Conversation
* The `DISTINCT pdo.deposit_object_id` is useless, since the query is grouped by the deposit_object_id column. * Make the last_modified column of the result aggregated to prevent database query errors. Fixes pkp/pkp-lib#1533
Member
|
Likewise, I presume this needs picking into |
Author
|
@asmecher Please do cherry-pick this one for the stable branch. |
Member
|
Cherry-picked! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISTINCT pdo.deposit_object_idis useless, since the query isgrouped by the deposit_object_id column.
database query errors.
Fixes pkp/pkp-lib#1533