[Journal Context] | About menu - Privacy Setting, Privacy setting link not being displayed when generic site-wide privacy setting is in place

[Tribunal33]

Valid Title

• I have updated the title to accurately reflect the bug description

Description

The generic privacy setting is not being displayed when the journal specific privacy setting is empty.

Preconditions : This will require admin access
Have a site wide privacy setting. Admin > Site Settings > Site Setup > Information > Privacy Statement
Empty the journal specific privacy setting in Journal Settings > Website > Setup > Privacy Statement (empty) (no local filled in either)

Steps to Reproduce

1. Navigate to the journal specific page
2. Select the about menu drop down

Expected Result

Should have the generic Site Wide Privacy statement displayed as a link in the drop down menu. Which should show the Site-Wide default privacy statement when no journal specific privacy message is entered.

Actual Result

No menu item is seen.
Full Video of issue: https://www.loom.com/share/a77d984dee5b4d079f578e791e711dbb

And it appears to be hidden in the navigation heirarchy. (Settings > Website > Setup > Navigation > Primary Navigation Menu > Edit > Privacy Statement (hidden)

Environment Details

No response

Application Version

OJS, OMP, OPS 3.5

Logs

No response

Additional Information

Scenario 1: config setting is On
Link for privacy statement should only be enabled/disabled by sitewide privacy statement text field. It should never be hidden in the navigation as long as there is some privacy statement in the admin site settings for the main language. Having this setting on should override journal specific privacy statements. Changing languages should show the privacy statement in the correct language if there is one and default to the main language if there isn't.

• Unknown scenario if there are 5 languages and only two privacy statements none of which are in the main language and user picks one of these but let's ignore this for now. This shouldn't be a problem if we make the main language the determining factor for enable/disable the link when the config setting is On

Scenario 2: config setting is Off
The link for privacy statement should never be hidden in the navigation as long as there is some privacy statement either in admin or journal specific settings. The journal specific privacy statement should override the sitewide statement as long as there is one. If there is not a journal specific statement in any language then it will default to this sitewide privacy statement. If this doesn't exist only then will the link be removed from the navigation. Changing languages should show the privacy statment in the correct language if there is one and default to the main language if there isn't for that journal.

[kaitlinnewson]

Hi @Tribunal33, there is a config setting in config.inc.php for sitewide_privacy_statement, which is Off by default - when this is off, then the site privacy statement won't appear, regardless of the journal's privacy statement settings.

[Tribunal33]

@kaitlinnewson I have been checking and I'm not sure that this setting would fix the current problem. If I am reading the config instructions correctly then if this settings is off then you can have both site-wide and journal specific privacy settings. If the settings is on you can only have the site-wide privacy setting. However, I couldn't see how the logic handles fall back defaults when this following scenario arose.

I currently have this setting sitewide-privacy_statement = Off which should grant both sitewide and journal specific privacy statements. When I remove the journal specific statements the sitewide statement should take over and I'm not seeing this happen.

I tried this with the setting On and Off and it didn't make a difference. I couldn't bring the privacy link back. I tried npm run build, clearning browser cache, clearing admin caches, restarting apache and DB,

[kaitlinnewson]

@Tribunal33 Here's where the logic is in the code:

pkp-lib/pages/about/AboutSiteHandler.php

Line 66 in 26d6b95

$enableSiteWidePrivacyStatement = Config::getVar('general', 'sitewide_privacy_statement');

If we are in a context (journal) and the sitewide privacy statement is Off, then the journal's localized privacy statement is used (which will fallback to other languages if the current is not set). Otherwise when set to On or we are in the "index" (sitewide) context (not easily accessible via site nav), the sitewide statement is used.

Would a quick call today on this be helpful?

[Tribunal33]

Ok looks like we figured out the issue isn't with the privacy statement per se but with the link from navigation not working even when the Sitewide-privacy_statement is turned On in the config. This has been happening since 3.4 at least. I will update the bug a the top with some user scenarios to address.

[Tribunal33]

I'm closing this as I think this is an enhancement and I created the new feature request : #11346