[Redesigned Dashboard] | Review assignment Views - Reviews Overdue, preivous round overdue reviews are being displayed

[Tribunal33]

Valid Title

• I have updated the title to accurately reflect the bug description

Description

Part of the edge case testing for previous review rounds. When a round has overdue reviews it would appear that the submission is showing up in the list but the value does not match. Two issues.

They should match
I don't think it should show up in the view list unless the current round Editorial activity has overdue reviews.

Steps to Reproduce

1. Preconditions : have a submission in review with reviewers that have overdue reviews.
2. Login with User/Role ' with access to move a submission to another review round
3. Navigate to the submission and select view
4. Select Create New review round
5. Select Reviews Overdue

Expected Result

Should only show submission with current round overdue reviews in this view

Actual Result

This view will detect overdue reviews from previous rounds even though the editorial activity is showing no overdue review activity.

Environment Details

No response

Application Version

OJS 3.5 RC2

Logs

No response

Additional Information

No response

[jardakotesovec]

@Tribunal33 That was great scenario to test.

@Vitaliy-1 Seems as easy fix, can you review: #11203

[jardakotesovec]

@Tribunal33 Merged to 3.5 and main. Should be fine now

[Tribunal33]

Still seeing the submissions with overdue reviews from previous rounds being filtered into this Reviews overdue view.

[jardakotesovec]

@Tribunal33 Oki, so my testing scenario was with review being overdue. While yours is with request for review being overdue. It turned out there is one more bug to address for that scenario.

@Vitaliy-1 I think right fix for this is just to improve condition grouping - #11215 . Can you please review.

Before the change we had:

SELECT "s".*
FROM "submissions" AS "s"
LEFT JOIN "publications" AS "po" ON "s"."current_publication_id" = "po"."publication_id"
WHERE "s"."context_id" IN (?)
  AND "s"."status" IN (?)
  AND "s"."stage_id" IN (?,
                         ?)
  AND "s"."submission_id" IN
    (SELECT "ra"."submission_id"
     FROM "review_assignments" AS "ra"
     INNER JOIN
       (SELECT "rr"."submission_id",
               MAX(rr.round) AS current_round
        FROM "review_rounds" AS "rr"
        WHERE "rr"."stage_id" IN
            (SELECT "s"."stage_id"
             FROM "submissions" AS "s"
             WHERE "rr"."stage_id" = "s"."stage_id")
        GROUP BY "rr"."submission_id") AS "agrr" ON "ra"."submission_id" = "agrr"."submission_id"
     WHERE "ra"."round" = "agrr"."current_round"
       AND "ra"."declined" = ?
       AND "ra"."cancelled" = ?
       AND ("ra"."date_due" < ?
            AND "ra"."date_completed" IS NULL)
       OR ("ra"."date_response_due" < ?
           AND "ra"."date_confirmed" IS NULL))

After the change the condition for dates is grouped together:

SELECT count(*) AS AGGREGATE
FROM "submissions" AS "s"
LEFT JOIN "publications" AS "po" ON "s"."current_publication_id" = "po"."publication_id"
WHERE "s"."context_id" IN (?)
  AND "s"."status" IN (?)
  AND "s"."stage_id" IN (?,
                         ?)
  AND "s"."submission_id" IN
    (SELECT "ra"."submission_id"
     FROM "review_assignments" AS "ra"
     INNER JOIN
       (SELECT "rr"."submission_id",
               MAX(rr.round) AS current_round
        FROM "review_rounds" AS "rr"
        WHERE "rr"."stage_id" IN
            (SELECT "s"."stage_id"
             FROM "submissions" AS "s"
             WHERE "rr"."stage_id" = "s"."stage_id")
        GROUP BY "rr"."submission_id") AS "agrr" ON "ra"."submission_id" = "agrr"."submission_id"
     WHERE "ra"."round" = "agrr"."current_round"
       AND "ra"."declined" = ?
       AND "ra"."cancelled" = ?
       AND (("ra"."date_due" < ?
             AND "ra"."date_completed" IS NULL)
            OR ("ra"."date_response_due" < ?
                AND "ra"."date_confirmed" IS NULL)))

[Vitaliy-1]

Thanks. Yeah, missed that, it should be grouped.