Editorial reminder should not trigger for submission assignee with specific roles combination

[qlaboudigue]

Issue #11047
Might fix #10573

[CLAassistant]

All committers have signed the CLA.

[twakeford]

Is there any update on this?

[asmecher]

@qlaboudigue, thanks for the PR, and I'm sorry for the long delay in responding! I believe this won't have the desired effect. It looks like the change makes sure there is at least one ROLE_ID_MANAGER or ROLE_ID_SUB_EDITOR` assignment to the submission in order for a user to be notified, which should already be the case based on the code that invokes the reminder.

Instead, I think the desired effect is that Editors who are assigned to the submission but who are also assigned as reviewers should not receive the invitation. That is, the code should check whether the user has any review assignments, and if so, they should be skipped.

[twakeford]

Small addition to the above. I believe it should check to see whether they have any reviewer and/or author assignments to the submission, and if so, they should be skipped