pkp/pkp-lib#11087 consider masthead options in the old UserForm#11128
Merged
bozana merged 2 commits intopkp:stable-3_5_0from Apr 3, 2025
Merged
pkp/pkp-lib#11087 consider masthead options in the old UserForm#11128bozana merged 2 commits intopkp:stable-3_5_0from
bozana merged 2 commits intopkp:stable-3_5_0from
Conversation
asmecher
requested changes
Mar 19, 2025
Member
asmecher
left a comment
asmecher
left a comment
There was a problem hiding this comment.
A couple changes to request!
bozana
force-pushed
the
11087-3_5_0
branch
2 times, most recently
from
aa1b581 to
00911a2
Compare
asmecher
reviewed
Mar 20, 2025
asmecher
reviewed
Mar 20, 2025
asmecher
reviewed
Mar 20, 2025
bozana
force-pushed
the
11087-3_5_0
branch
4 times, most recently
from
5a4d688 to
c8b6763
Compare
Contributor
Author
|
Hi @asmecher, I changed the way those enumerations are used, s. second commit. Could you please take a look? |
|
|
Member
|
@bozana, I think something happened to the PRs -- there are a bunch of conflicts and other code now involved. Can you take a look? |
Contributor
Author
|
Ah, sorry @asmecher, I pushed the wrong branch... 🙈 |
Member
|
Thanks, @bozana, this looks good. I've reviewed but not tested; please go ahead, then assign the issue over to Beau for a spin through QA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
s. #11087