Conversation
ipula
force-pushed
the
ipula/i11118
branch
2 times, most recently
from
7991caa to
99fd632
Compare
defstat
requested changes
Mar 20, 2025
...ation/invitations/userRoleAssignment/handlers/UserRoleAssignmentInviteRedirectController.php
Show resolved
Hide resolved
...ses/invitation/invitations/userRoleAssignment/resources/UserRoleAssignmentInviteResource.php
Outdated
Show resolved
Hide resolved
...invitation/invitations/userRoleAssignment/resources/BaseUserRoleAssignmentInviteResource.php
Outdated
Show resolved
Hide resolved
ipula
force-pushed
the
ipula/i11118
branch
2 times, most recently
from
d583d6b to
0f738a5
Compare
defstat
requested changes
Mar 21, 2025
.../invitation/invitations/userRoleAssignment/handlers/UserRoleAssignmentInviteUIController.php
Outdated
Show resolved
Hide resolved
.../invitation/invitations/userRoleAssignment/handlers/UserRoleAssignmentInviteUIController.php
Show resolved
Hide resolved
.../invitation/invitations/userRoleAssignment/handlers/UserRoleAssignmentInviteUIController.php
Outdated
Show resolved
Hide resolved
defstat
requested changes
Mar 26, 2025
...ses/invitation/invitations/userRoleAssignment/resources/UserRoleAssignmentInviteResource.php
Outdated
Show resolved
Hide resolved
...ses/invitation/invitations/userRoleAssignment/resources/UserRoleAssignmentInviteResource.php
Outdated
Show resolved
Hide resolved
ipula
force-pushed
the
ipula/i11118
branch
2 times, most recently
from
28451f8 to
6c25c8b
Compare
defstat
requested changes
Apr 3, 2025
Contributor
defstat
left a comment
defstat
left a comment
There was a problem hiding this comment.
@ipula Thanks for your work on this! I’ve left a few comments that are important for ensuring everything works as expected.
I also proposed some changes here: ipula#4 — could you please review them and test if they work for the specific invitation case?
You'll also need to make sure the UI is updated to call the new handler introduced in that PR.
Once we confirm this works, we can move on to test the other invitation types and address any potential security concerns.
Thanks again — let me know if anything’s unclear or if you'd like to discuss further. Ping me when ready.
pkp#11118 Proposed fixes for cleanup
Contributor
Author
|
close this PR. this related to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#11118