Development

[pladisdev]

No description provided.

[Copilot]

Pull request overview

This pull request introduces several user-facing improvements and backend reliability enhancements for the Chat Yapper TTS application. The changes focus on improving the user experience with better notifications, concurrent message limiting, and enhanced OAuth token management for Twitch and YouTube integrations.

Key Changes:

• Toast notification system for user feedback on browser autoplay restrictions and authentication issues
• Parallel message limiting with configurable yapper limits and queue overflow handling
• Enhanced authentication with automatic OAuth token refresh for Twitch and YouTube
• UI improvements including username display in chat bubbles, text size adjustment, and quick status view

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 17 comments.

Show a summary per file

File	Description
frontend/src/pages/YappersPage.jsx	Adds toast notifications for autoplay errors, username display in chat bubbles, and user interaction tracking
frontend/src/pages/SettingsPage.jsx	Introduces quick status view sidebar, global TTS toggle button, and improved layout
frontend/src/index.css	Implements text size scaling system with CSS custom properties
frontend/src/hooks/useToast.js	New custom hook for toast notification state management
frontend/src/components/ui/toast.jsx	Toast notification UI component with auto-close functionality
frontend/src/components/ui/badge.jsx	New badge component for status indicators
frontend/src/components/settings/TwitchIntegration.jsx	Adds auth error detection/handling, redeem filter management, and connection testing
frontend/src/components/settings/QuickStatusView.jsx	New status sidebar showing system state at a glance
frontend/src/components/settings/GeneralSettings.jsx	Adds yapper limit controls, font size toggle, and queue overflow settings
frontend/src/components/settings/ChatBubbleSettings.jsx	Adds username display toggle and color customization
frontend/src/components/VoiceManager.jsx	Adds callback for voice changes to update parent components
backend/app.py	Implements parallel message limiting with audio duration-based counter, OAuth token refresh, and comprehensive auth error handling
backend/routers/auth.py	Adds automatic token refresh for Twitch/YouTube, auth error endpoints, and connection testing
backend/routers/system.py	Adds debug endpoints for TTS state inspection and parallel limit testing
backend/modules/youtube_listener.py	Improves error handling for 401 auth errors with automatic credential refresh
backend/modules/twitch_listener.py	Adds TwitchIO 3.x credential validation
backend/modules/settings_defaults.json	Adds defaults for new settings (text size, parallel limits, username display, redeem filter)
backend/tests/conftest.py	Adds mock Twitch credentials for TwitchIO 3.x compatibility in tests
deployment/build.py	Adds TwitchIO version checking and credential validation warnings
README.md	Updates changelog with v1.2.2 features

Comments suppressed due to low confidence (5)

frontend/src/pages/YappersPage.jsx:1491

• The condition check chatMessages[id].username on line 1491 could fail if chatMessages[id] is undefined. Consider using optional chaining for safety:

(settings?.bubbleShowUsername ?? true) && chatMessages[id]?.username

This prevents runtime errors when accessing properties of potentially undefined objects.

                      {(settings?.bubbleShowUsername ?? true) && chatMessages[id].username && (

frontend/src/pages/YappersPage.jsx:1514

• Similar issue on line 1514 - the check needs optional chaining to handle cases where chatMessages[id] might be undefined:

paddingTop: (settings?.bubbleShowUsername ?? true) && chatMessages[id]?.username ? '4px' : '8px'

This prevents errors when the chat message object doesn't exist.

                        paddingTop: (settings?.bubbleShowUsername ?? true) && chatMessages[id].username ? '4px' : '8px'

frontend/src/pages/YappersPage.jsx:1485

• Similar to the grid mode, the condition check for chatMessages[id] on line 1485 should also check for the message property since the data structure changed from string to object:

chatMessages[id]?.message

Without this fix, the chat bubble won't render properly in popup mode when there's an empty message object.

                  {settings?.chatBubblesEnabled !== false && chatMessages[id] && (

frontend/src/pages/YappersPage.jsx:1136

• The condition check for chatMessages[slot.id] on line 1136 will fail when chatMessages[slot.id] is falsy (undefined, null, or an empty object). Since chatMessages was changed from storing strings to storing objects with { message, username } structure, this check should be updated to:

chatMessages[slot.id]?.message

This ensures the check properly validates that a message exists in the object structure.

                  {(settings?.bubbleShowUsername ?? true) && chatMessages[slot.id].username && (

backend/app.py:654

• Variable result is not used.

            result = task.result()

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The raise statement on line 1645 appears to be misplaced. This line is in the middle of the handle_event function, after checking if filtered text differs from original text, but it's not inside any exception handler. This will cause an unhandled exception to be raised whenever text filtering modifies the message.

The code should either:

1. Remove this raise statement if it was added by mistake
2. Replace it with appropriate logic (e.g., logging or continuing execution)

Suggested change

raise

[Copilot]

Spelling error: "notifcations" should be "notifications"

Suggested change

	- Some more twitch fixes and improved notifcations
	- Some more twitch fixes and improved notifications

[Copilot]

The decrement_after_audio function is created as a fire-and-forget task without any error handling. If an exception occurs during the sleep or when calling decrement_tts_count() or process_parallel_message_queue(), it will be silently swallowed.

Consider wrapping the async function with try-except:

async def decrement_after_audio():
    try:
        await asyncio.sleep(decrement_delay)
        decrement_tts_count()
        process_parallel_message_queue()
    except Exception as e:
        logger.error(f"Error in decrement_after_audio: {e}", exc_info=True)
        # Still decrement to prevent counter drift
        decrement_tts_count()

Suggested change

	await asyncio.sleep(decrement_delay)
	decrement_tts_count()
	# Process any queued messages now that a slot is free
	process_parallel_message_queue()
	try:
	await asyncio.sleep(decrement_delay)
	decrement_tts_count()
	# Process any queued messages now that a slot is free
	process_parallel_message_queue()
	except Exception as e:
	logger.error(f"Error in decrement_after_audio: {e}", exc_info=True)
	# Still decrement to prevent counter drift
	decrement_tts_count()

[Copilot]

There's a potential race condition in the parallel limiting logic. The counter is incremented in check_parallel_limits_and_process (line 1599), but if the TTS processing fails early (before the async task completes), the decrement happens in the exception handler. However, if process_tts_message is called directly from check_parallel_limits_and_process and fails synchronously before reaching the fire-and-forget decrement task, the counter could be decremented twice: once in the exception handler and once by the scheduled task.

Consider tracking the scheduled decrement tasks so they can be cancelled if an early error occurs, or use a flag to prevent double-decrement.

Suggested change

	try:
	await process_tts_message(evt)
	return True
	except Exception as e:
	# If processing failed, decrement counter
	decrement_tts_count()
	logger.error(f"TTS processing failed for {username}: {e}", exc_info=True)
	return False
	decremented = False
	try:
	await process_tts_message(evt)
	except Exception as e:
	# If processing failed, decrement counter
	decrement_tts_count()
	decremented = True
	logger.error(f"TTS processing failed for {username}: {e}", exc_info=True)
	return False
	# Only decrement if not already done in exception
	if not decremented:
	decrement_tts_count()
	return True

[Copilot]

The toast ID generation using Date.now() + Math.random() on line 7 could potentially create collisions if multiple toasts are created in rapid succession within the same millisecond. While unlikely, a more robust approach would be to use a counter or UUID.

Consider:

const id = `${Date.now()}-${Math.random()}`

or use a counter-based approach for guaranteed uniqueness.

Suggested change

	const id = Date.now() + Math.random()
	const id = crypto.randomUUID()

[Copilot]

Unused imports CardHeader, CardTitle.

Suggested change

	import { Card, CardContent, CardHeader, CardTitle } from '../ui/card'
	import { Card, CardContent } from '../ui/card'

[Copilot]

Unused imports CheckCircle2, XCircle.

Suggested change

	Users,
	CheckCircle2,
	XCircle
	Users

[Copilot]

Unused import useState.

Suggested change

	import React, { useState, useEffect } from 'react'
	import React, { useEffect } from 'react'

[Copilot]

This use of variable 'settings' always evaluates to true.

[Copilot]

Variable youtube_refresh_attempted is not used.

Suggested change

youtube_refresh_attempted = False

[github-actions]

✅ Windows Build Successful

Executable: ChatYapper.exe (68.29 MB)
MSI Installer: ChatYapper-1.2.2.msi (67.64 MB)
App Version: 1.2.2
Build ID: build-v1.2.2-2025.11.22-78504eb
Commit: 78504eb

Build Status

• ✅ Windows executable & MSI installer
• 🔄 Linux build (check separate job)
• 🔄 Docker image (check separate job)

Download the artifacts from the workflow run to test before merging.

Once merged to main, an official release will be created automatically with tag v1.2.2.

[github-actions]

🐳 Docker Image Built Successfully

Image: ghcr.io/pladisdev/chat-yapper:pr-78504eb
Tag: pr-78504eb

Test this PR with Docker:

docker pull ghcr.io/pladisdev/chat-yapper:pr-78504eb

docker run -d \
  --name chat-yapper-pr \
  -p 8069:8008 \
  -e TWITCH_CLIENT_ID=your_id \
  -e TWITCH_CLIENT_SECRET=your_secret \
  ghcr.io/pladisdev/chat-yapper:pr-78504eb

Access at: http://localhost:8069

The Docker image will be published to the GitHub Container Registry when merged to main.