Skip to content

Add Assets as a product #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pbernasconi merged 4 commits into from
Apr 27, 2018
Merged

Add Assets as a product #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
617bf3d
Add Assets as a product
pbernasconi Apr 27, 2018
f2ab5df
Add assets to assertions
pbernasconi Apr 27, 2018
881f397
undo last fix
pbernasconi Apr 27, 2018
ffc6e91
eek should be 6 products
pbernasconi Apr 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/com/plaid/client/request/common/Product.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import com.google.gson.annotations.SerializedName;

public enum Product {
@SerializedName("assets") ASSETS,
@SerializedName("balance") BALANCE,
@SerializedName("credit_details") CREDIT_DETAILS,
@SerializedName("income") INCOME,
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/plaid/client/integration/InstitutionsGetByIdTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public void testSuccess() throws Exception {
assertEquals(TARTAN_BANK_INSTITUTION_ID, institution.getInstitutionId());
assertEquals(Arrays.asList("code", "list", "questions", "selections"), institution.getMfa());
assertEquals("Tartan Bank", institution.getName());
assertEquals(Arrays.asList(Product.AUTH, Product.BALANCE, Product.TRANSACTIONS, Product.CREDIT_DETAILS, Product.INCOME, Product.IDENTITY),
assertEquals(Arrays.asList(Product.ASSETS, Product.AUTH, Product.BALANCE, Product.TRANSACTIONS, Product.CREDIT_DETAILS, Product.INCOME, Product.IDENTITY),
institution.getProducts());
}

Expand Down
6 changes: 3 additions & 3 deletions src/test/java/com/plaid/client/integration/ItemCreateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public void testItemCreateFullyLoadedRequestSuccess() throws Exception {
assertTrue(response.body().isItemResponse());
assertFalse(response.body().isMfaResponse());

assertEquals(Arrays.asList(Product.AUTH, Product.BALANCE, Product.CREDIT_DETAILS, Product.IDENTITY, Product.INCOME),
assertEquals(Arrays.asList(Product.ASSETS, Product.AUTH, Product.BALANCE, Product.CREDIT_DETAILS, Product.IDENTITY, Product.INCOME),
response.body().getItem().getAvailableProducts());
assertEquals(1, response.body().getItem().getBilledProducts().size());
assertEquals(Arrays.asList(Product.TRANSACTIONS), response.body().getItem().getBilledProducts());
Expand Down Expand Up @@ -157,8 +157,8 @@ public void testItemCreateWithCredentialsToken() throws Exception {
assertTrue(response.body().isItemResponse());
assertFalse(response.body().isMfaResponse());

assertEquals(5, response.body().getItem().getAvailableProducts().size());
assertEquals(Arrays.asList(Product.AUTH, Product.BALANCE, Product.CREDIT_DETAILS, Product.IDENTITY, Product.INCOME),
assertEquals(6, response.body().getItem().getAvailableProducts().size());
assertEquals(Arrays.asList(Product.ASSETS, Product.AUTH, Product.BALANCE, Product.CREDIT_DETAILS, Product.IDENTITY, Product.INCOME),
response.body().getItem().getAvailableProducts());
assertEquals(1, response.body().getItem().getBilledProducts().size());
assertEquals(Arrays.asList(Product.TRANSACTIONS), response.body().getItem().getBilledProducts());
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/plaid/client/integration/ItemMfaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ private static void assertItemResponse(Response<ItemCreateResponse> itemCreateRe
assertSuccessResponse(response);
assertTrue(response.body().isItemResponse());
assertFalse(response.body().isMfaResponse());
assertEquals(Arrays.asList(Product.AUTH, Product.BALANCE, Product.CREDIT_DETAILS, Product.IDENTITY, Product.INCOME),
assertEquals(Arrays.asList(Product.ASSETS, Product.AUTH, Product.BALANCE, Product.CREDIT_DETAILS, Product.IDENTITY, Product.INCOME),
response.body().getItem().getAvailableProducts());
assertEquals(1, response.body().getItem().getBilledProducts().size());
assertThat(response.body().getItem().getBilledProducts(), hasItems(Product.TRANSACTIONS));
Expand Down