add apex and dwolla processor token support#87
Merged
michaelckelly merged 3 commits intomasterfrom Aug 14, 2017
Merged
Conversation
jeeyoungk
reviewed
Jul 26, 2017
| * Request for /item/public_token/exchange endpoint. | ||
| */ | ||
| public final class ApexProcessorTokenCreateRequest extends BaseAccessTokenRequest { | ||
| private String accessToken; |
Contributor
There was a problem hiding this comment.
BaseAccessTokenRequest already defines accessToken, so this line should be removed - it's not used anywhere.
Contributor
Author
There was a problem hiding this comment.
⚡ this file is actually extraneous, removing
jeeyoungk
reviewed
Jul 26, 2017
| private String accountId; | ||
|
|
||
| public ItemApexProcessorTokenCreateRequest(String accessToken, String accountId) { | ||
| super(accessToken); |
jeeyoungk
reviewed
Jul 26, 2017
| private String accountId; | ||
|
|
||
| public ItemDwollaProcessorTokenCreateRequest(String accessToken, String accountId) { | ||
| super(accessToken); |
Contributor
|
Mostly looks good! |
|
Hi! Is there anything I can do to help get this PR merged? It's blocking for my use case right now. |
|
Any update @jeeyoungk @michaelckelly? Would love to see this go in! |
Contributor
Author
|
@AndyMoreland and @emarx - thanks for the ping, looking to get this merged + released to Maven today! |
Contributor
Author
|
@jeeyoungk Your feedback has been addressed, going to go ahead and merge to get this published |
Contributor
Author
|
@AndyMoreland and @emarx - this change has been released to Maven as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #86