Conversation
joyzheng
reviewed
May 2, 2018
Contributor
joyzheng
left a comment
joyzheng
left a comment
There was a problem hiding this comment.
Awesome! I think I'm missing where the breaking change is happening to prompt a major release -- mind pointing it out?
|
|
||
| def http_request(url, method=None, data=None, timeout=DEFAULT_TIMEOUT): | ||
| response = _requests_http_request(url, method, data or {}, timeout) | ||
| def http_request( |
Contributor
There was a problem hiding this comment.
let's keep the argument order consistent between http_request and _requests_http_request (the order of headers and timeout is reversed between the two).
Contributor
Author
There was a problem hiding this comment.
Great catch! You're right about the major release, my mistake.
Contributor
Author
|
Closing as we want to keep this functionality internal until the full versioning release. |
Contributor
|
🐢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for api version 2018-05-22