Removed occurences of mutable kwargs#139
Merged
michaelckelly merged 1 commit intoplaid:masterfrom Feb 25, 2019
Merged
Conversation
Contributor
|
can we add a lint rule to prevent this in the future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kwargs are evaluated import time and for objects (in this case the dict) the function is passed a reference to the same dict on each call. This is an anti-pattern because it introduces state in functions in an unexpected way (if the dict is mutated then subsequent function calls are affected by this mutation too).
This change is backwards compatible and removes risk of subtle and hard-to-identify bugs.