Conversation
| code, | ||
| display_message, | ||
| request_id="", | ||
| causes=[], |
Contributor
There was a problem hiding this comment.
I think in general in python you want to avoid passing in {} or [] as a default argument. Because otherwise all callers of this function will default to the same instance, and if it's ever mutated bad things happen in the future.
Contributor
There was a problem hiding this comment.
Yep, either make it a tuple, or use None and do for cause in (causes or []) below.
| cause['error_message'], | ||
| cause['error_type'], | ||
| cause['error_code'], | ||
| cause['display_message'] if 'display_message' in cause else '', |
Contributor
There was a problem hiding this comment.
cause.get('display_message', '')
?
mattiskan
reviewed
Feb 11, 2019
| cause['error_code'], | ||
| cause['display_message'] if 'display_message' in cause else '', | ||
| ) | ||
| self.causes.append(c) |
Contributor
There was a problem hiding this comment.
nit: can we make this a list-comprehension?
added 4 commits
February 12, 2019 13:45
Contributor
|
lg2m |
added 2 commits
February 13, 2019 10:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.